pinctrl-rockchip: Change wrong initial assumptions
Get series with b4
b4 am 11862890.WUjscWaP3U@diegoVersions newest first · linked by author and title
- v2 Latest8 patches 0 repliesNew
- v18 patches 0 repliesSuperseded
Changes in v2 from the cover letter
- add select MFD_SYSCON as suggested by Max
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | pinctrl: rockchip: do not require 2nd register areaDocumentation/ drivers/ | +14 | 0 replies | |
| 2/8 | pinctrl: rockchip: use regmaps instead of raw mappingsdrivers/ drivers/ | +81 | 0 replies | |
| 3/8 | pinctrl: rockchip: rockchip_pinctrl in rockchip_get_bank_datadrivers/ | +9 | 0 replies | |
| 4/8 | pinctrl: rockchip: let pmu registers be supplied by a syscondrivers/ | +15 | 0 replies | |
| 5/8 | pinctrl: rockchip: only map bank0-pull-region when pmu regmap missingdrivers/ | +19 | 0 replies | |
| 6/8 | pinctrl: rockchip: base regmap supplied by a syscondrivers/ | +28 | 0 replies | |
| 7/8 | dt-bindings: adapt rockchip-pinctrl doc to changed bindingsDocumentation/ | +20 | 0 replies | |
| 8/8 | ARM: dts: rockchip: convert pinctrl nodes to new bindingsarch/ arch/ arch/ | +12 | 1 reply |
Reviews trailers per patch
1 of 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Max Schwarz | Linus Walleij |
|---|---|---|
| Series | A-b | |
| 1/8 | T-b | |
| 2/8 | T-b | |
| 3/8 | T-b | |
| 4/8 | T-b | |
| 5/8 | T-b | |
| 6/8 | T-b | |
| 7/8 | T-b | |
| 8/8 | T-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/8] pinctrl-rockchip: Change wrong initial assumptions
Initially due to lack of documentation and (personal) understanding I assumed that the area holding the iomux settings would be separate from everything else, while in fact the grf registers contain not only pinctrl stuff but also dma, usb-phy and general soc-status settings. Also things like drive-strength we do not support currently are intermixed.
The same is true for the pmu, which does not only contain power domains but also the system reset as well as well as general registers surviving system-resets. Additionally the rk3188 moved parts of the pull-setting registers into the pmu space.
While this wasn't a problem until now, the upcoming rk3288 introduces additional changes to both the grf and pmu areas. On it even part of the pinmux registers move into the pmu space.
The code in it's current form supports both the old as well as the changed bindings.
As stated in the v1 thread, this is also a first step to deprecate the wrongly included gpio-controllers which now duplicate the recently added gpio-dwapb, that should be used instead.
changes since v1:
- add select MFD_SYSCON as suggested by Max
Heiko Stuebner (8):
pinctrl: rockchip: do not require 2nd register area
pinctrl: rockchip: use regmaps instead of raw mappings
pinctrl: rockchip: rockchip_pinctrl in rockchip_get_bank_data
pinctrl: rockchip: let pmu registers be supplied by a syscon
pinctrl: rockchip: only map bank0-pull-region when pmu regmap missing
pinctrl: rockchip: base regmap supplied by a syscon
dt-bindings: adapt rockchip-pinctrl doc to changed bindings
ARM: dts: rockchip: convert pinctrl nodes to new bindings
.../bindings/pinctrl/rockchip,pinctrl.txt | 28 +++- arch/arm/boot/dts/rk3066a.dtsi | 2 +- arch/arm/boot/dts/rk3188.dtsi | 9 +- arch/arm/boot/dts/rk3xxx.dtsi | 9 +- drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/pinctrl-rockchip.c | 178 +++++++++++++++------ 6 files changed, 165 insertions(+), 62 deletions(-)
Signature · 1 line
1.9.0