Skip to content

arm: sa1100: add cpu clock for fbdev and pcmcia

Dmitry Eremin-Solenikov linux-fbdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5arm: sa1100: add cpu clockarch/arm/mach-sa1100/clock.c+34 -70 replies
2/5arm: sa1100: add a clock alias for sa1111 pcmcia devicearch/arm/mach-sa1100/clock.c+2 -00 replies
3/5fbdev: sa1100fb: make use of device clockdrivers/video/fbdev/sa1100fb.c drivers/video/fbdev/sa1100fb.h+18 -70 replies
4/5pcmcia: sa1100: make use of device clockdrivers/pcmcia/sa1100_generic.c drivers/pcmcia/sa11xx_base.c+13 -20 replies
5/5pcmcia: sa1111: provide device clockdrivers/pcmcia/sa1111_generic.c+4 -00 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchTomi Valkeinen
1/5
2/5
3/5A-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RESEND 0/5] arm: sa1100: add cpu clock for fbdev and pcmcia

These patches are required to make SL-5500 (collie) to work properly. Framebuffer maintainer added his ack to the respective patch. PCMCIA subsystem seems to be unmaintained at this moment. Russell, could you please review and hopefully ack these patches?

On SA-1100 framebuffer and PCMCIA drivers make use of cpufreq_get(0) function call to determine the cpu frequency. Russell's commit 1937f5b91833e2e8e53bcc821fc7a5fbe6ccb9b5 (ARM: fix sa1100 build) fixed the build issues, but broke two devices (Collie and Jornada720). For those two boards the cpufreq code gets compiled but is not enabled (as board files do not provide timing information for the CPUFREQ driver). Thus cpufreq_get(0) returns incorrect value and incorrect timings get programmed into the hardware.

PXA2xx (the very similar platform) uses Clock API to determine CPU frequency both in framebuffer and PCMCIA drivers. These patches make similar changes to StrongARM drivers.