Skip to content

xen: arm: xgene bug fixes + support for McDivitt

Ian Campbell xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 9 repliesIn review
  2. v14 patches 15 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5xen: arm: Add earlyprintk for McDivitt.xen/arch/arm/Rules.mk+5 -01 reply
2/5xen: arm: Drop EARLY_PRINTK_BAUD from entries which don't set ..._INIT_UARTxen/arch/arm/Rules.mk+0 -71 reply
3/5xen: arm: correct off by one in xgene-storm's map_one_mmioxen/arch/arm/platforms/xgene-storm.c+3 -31 reply
4/5xen: arm: correct specific mappings for PCIE0 on X-Genexen/arch/arm/platforms/xgene-storm.c+2 -160 replies
5/5xen: arm: Support the other 4 PCI buses on Xgenexen/arch/arm/platforms/xgene-storm.c+76 -133 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJulien GrallPranavkumar Sawargaonkar
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/5 v2 for-4.5] xen: arm: xgene bug fixes + support for McDivitt

These patches:

* fix up an off by one bug in the xgene mapping of additional PCI bus resources, which would cause an additional extra page to be mapped
* correct the size of the mapped regions to match the docs
* adds support for the other 4 PCI buses on the chip, which enables mcdivitt and presumably most other Xgene based platforms which uses PCI buses other than pcie0.
* adds earlyprintk for the mcdivitt platform

They can also be found at:
git://xenbits.xen.org/people/ianc/xen.git mcdivitt-v2

McDivitt is the X-Gene based HP Moonshot cartridge (McDivitt is the code name, I think the product is called m400, not quite sure).

Other than the bug fixes I'd like to see the mcdivitt support (specifically the "other 4 PCI buses" one) in 4.5 because Moonshot is an interesting and exciting platform for arm64. It is also being used for ongoing work on Xen on ARM on Openstack in Linaro. The earlyprintk patch is totally harmless unless it's explicitly enabled at compile time, IMHO if we are taking the rest we may as well throw it in...

The risk here is that we break the existing support for the Mustang platform, which would be the most likely failure case for the second patch. I've tested these on a Mustang, including firing up a PCI NIC device. The new mappings are a superset of the existing ones so the potential for breakage should be quite small.

I've also successfully tested on a McDivitt.

Ian.