Skip to content

sunrpc: fixes and cleanups for svc creation and thread handling

Jeff Layton linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10sunrpc: release svc_pool_map reference when serv allocation failsnet/sunrpc/svc.c+7 -50 replies
2/10sunrpc: add a generic rq_flags field to svc_rqst and move rq_secure to itfs/nfsd/nfscache.c fs/nfsd/nfsfh.c include/linux/sunrpc/svc.h +2 more+22 -100 replies
3/10sunrpc: move rq_local field to rq_flagsfs/nfsd/vfs.c include/linux/sunrpc/svc.h include/trace/events/sunrpc.h +1 more+9 -50 replies
4/10sunrpc: move rq_usedeferral flag to rq_flagsfs/nfsd/nfs4proc.c include/linux/sunrpc/svc.h include/trace/events/sunrpc.h +2 more+10 -90 replies
5/10sunrpc: move rq_dropme flag into rq_flagsfs/nfsd/nfssvc.c include/linux/sunrpc/svc.h include/trace/events/sunrpc.h +2 more+9 -90 replies
6/10sunrpc: move rq_splice_ok flag into rq_flagsfs/nfsd/nfs4proc.c fs/nfsd/nfs4xdr.c fs/nfsd/vfs.c +4 more+13 -120 replies
7/10sunrpc: move rq_cachetype field to better optimize spaceinclude/linux/sunrpc/svc.h+1 -10 replies
8/10sunrpc: convert sp_task_pending flag to use atomic bitopsinclude/linux/sunrpc/svc.h net/sunrpc/svc_xprt.c+6 -50 replies
9/10sunrpc: have svc_wake_up only deal with pool 0net/sunrpc/svc_xprt.c+16 -210 replies
10/10sunrpc: require svc_create callers to pass in meaningful shutdown routinefs/lockd/svc.c net/sunrpc/svc.c+1 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] sunrpc: fixes and cleanups for svc creation and thread handling

Hi Bruce!

Patch #1 in this series is a bugfix, but probably isn't worth sending to stable. The rest are just cleanups in preparation for some other patches that I have queued up. Can you consider these for 3.19?

The main one that I'm hoping to send soon for v3.19 is the one to help reduce the pool->sp_lock contention on busy servers. I have some preliminary numbers that look pretty good, but one of our QA folks is working on getting some better ones from a more rigorous test. I'll send those along in a few days once I have those numbers.

Jeff Layton (10):
sunrpc: release svc_pool_map reference when serv allocation fails
sunrpc: add a generic rq_flags field to svc_rqst and move rq_secure to
it
sunrpc: move rq_local field to rq_flags
sunrpc: move rq_usedeferral flag to rq_flags
sunrpc: move rq_dropme flag into rq_flags
sunrpc: move rq_splice_ok flag into rq_flags
sunrpc: move rq_cachetype field to better optimize space
sunrpc: convert sp_task_pending flag to use atomic bitops
sunrpc: have svc_wake_up only deal with pool 0
sunrpc: require svc_create callers to pass in meaningful shutdown
routine

 fs/lockd/svc.c                    |  2 +-
 fs/nfsd/nfs4proc.c                |  6 ++---
 fs/nfsd/nfs4xdr.c                 |  8 +++---
 fs/nfsd/nfscache.c                |  4 +--
 fs/nfsd/nfsfh.c                   |  2 +-
 fs/nfsd/nfssvc.c                  |  2 +-
 fs/nfsd/vfs.c                     |  6 ++---
 include/linux/sunrpc/svc.h        | 22 +++++++++--------
 include/trace/events/sunrpc.h     | 24 +++++++++++++-----
 net/sunrpc/auth_gss/svcauth_gss.c |  2 +-
 net/sunrpc/svc.c                  | 23 +++++++++---------
 net/sunrpc/svc_xprt.c             | 51 ++++++++++++++++++---------------------
 net/sunrpc/svcsock.c              |  5 +++-
 13 files changed, 85 insertions(+), 72 deletions(-)
Signature · 1 line
2.1.0