Skip to content

clockevents: introduce ->set_dev_mode() and convert a few drivers

Kevin Hilman linux-arm-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2clockevents: introduce ->set_dev_mode() which can return errorinclude/linux/clockchips.h kernel/time/clockevents.c kernel/time/timer_list.c+26 -51 reply
2/2clockevents: migrate some drivers to new ->set_dev_mode()drivers/clocksource/arm_arch_timer.c drivers/clocksource/bcm2835_timer.c drivers/clocksource/bcm_kona_timer.c +2 more+65 -380 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKevin HilmanPreeti U Murthy
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] clockevents: introduce ->set_dev_mode() and convert a few drivers

From: Kevin Hilman <[email protected]>

Currently, the ->set_mode() method of a clockevent device is not allowed to fail, so it has no return value. In order to add new clockevent modes, and allow the setting of those modes to fail, we need the clockevent core to be able to detect when setting a mode fails.

Rather than changing the current ->set_mode() and requiring all clockevent devices to change immedately, introduce a new mode setting method ->set_dev_mode() which returns 'int'.

In addition, migrate a few drivers over to the new method to demonstrate how the new method is to be used, and how to convert.

Proposal for new method originally suggested by Thomas Gleixner[1].

[1] https://lkml.org/lkml/2014/5/10/86

Viresh Kumar (2):
clockevents: introduce ->set_dev_mode() which can return error
clockevents: migrate some drivers to new ->set_dev_mode()

 drivers/clocksource/arm_arch_timer.c     | 46 +++++++++++++++++---------------
 drivers/clocksource/bcm2835_timer.c      | 10 +++----
 drivers/clocksource/bcm_kona_timer.c     | 15 ++++++++---
 drivers/clocksource/i8253.c              | 11 +++++---
 drivers/clocksource/time-armada-370-xp.c | 21 +++++++++++----
 include/linux/clockchips.h               |  5 +++-
 kernel/time/clockevents.c                | 21 ++++++++++++---
 kernel/time/timer_list.c                 |  5 +++-
 8 files changed, 91 insertions(+), 43 deletions(-)
Signature · 1 line
2.1.3