Skip to content

drm/i915 Avoid long delays when reading EDID on eDP

Egbert Eich intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915: Try to avoid pps_{lock, unlock}() on DP portsdrivers/gpu/drm/i915/intel_dp.c+28 -201 reply
2/5drm/DP: Create pointer to generic DPCD access functiondrivers/gpu/drm/drm_dp_helper.c include/drm/drm_dp_helper.h+11 -20 replies
3/5drm/DP: Export drm_dp_i2c_xfer() DP helper functiondrivers/gpu/drm/drm_dp_helper.c include/drm/drm_dp_helper.h+4 -10 replies
4/5drm/DP: Export drm_dp_dpcd_access() DP helper functiondrivers/gpu/drm/drm_dp_helper.c include/drm/drm_dp_helper.h+6 -10 replies
5/5drm/i915/eDP: Move pps_lock() and edp_panel_vdd_on() to topdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+100 -210 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] drm/i915 Avoid long delays when reading EDID on eDP

For eDP in the Intel driver pps_lock()/unlock() need to be called before initiating an I2C/AUX channel transfer. These operations can be quite expensive - especially on values for HZ lower than 1000.
It is therefore better to perfrom this locking/unlocking only once, ie at the beginning and at the end of the entire I2C transfer. The current design of drm_dp_helper.c doesn't allow this. This patchset modifies drm_dp_helper.c and moves the locking/unlocking operation to the top.
This fixes the long delay observed in
https://bugs.freedesktop.org/show_bug.cgi?id=86201

Egbert Eich (4):
drm/DP: Create pointer to generic DPCD access function drm/DP: Export drm_dp_i2c_xfer() DP helper function drm/DP: Export drm_dp_dpcd_access() DP helper function drm/i915/eDP: Move pps_lock() and edp_panel_vdd_on() to top

Ville Syrjälä (1):
drm/i915: Try to avoid pps_{lock,unlock}() on DP ports

 drivers/gpu/drm/drm_dp_helper.c  |  11 ++--
 drivers/gpu/drm/i915/intel_dp.c  | 132 +++++++++++++++++++++++++++++++--------
 drivers/gpu/drm/i915/intel_drv.h |   5 ++
 include/drm/drm_dp_helper.h      |  14 +++++
 4 files changed, 133 insertions(+), 29 deletions(-)
Signature · 6 lines
1.8.4.5

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx