Skip to content

HID: wacom: Fix generic multitouch device handling

Jason Gerecke linux-input 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3HID: wacom: Consult the application usage when determining field typedrivers/hid/wacom_wac.c+4 -22 replies
2/3HID: wacom: Manually declare ABS_{X,Y} for pointer emulationdrivers/hid/wacom_wac.c+4 -61 reply
3/3HID: wacom: Report input events immediately upon receiptdrivers/hid/wacom_wac.c+44 -331 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] HID: wacom: Fix generic multitouch device handling

This set of patches addresses the problems that I had getting Benjamin's "HID generic handling" patches. Each of the patches addresses a seprate issue I encountered:

* Patch 1/3: The devices that I'm using have some usages outside of a logical or physical collection container which prevents the reports from being sent. I'm not sure if keying on the application collection is ideal, but it does do the job.

* Patch 2/3: The devices that I'm using put their X and Y usages after the finger count, which prevents the (compatibility) ABS_X and ABS_Y axes from being initialized. This patch just guarantees that they'll be initialized.

* Patch 3/3: Benjamin's original code seemed to only report data about the last finger in a multitouch report since information about "earlier" fingers would be overwritten. This patch changes the logic so that we immediately report field values whenever we can (there are some cases that we can't -- the tip/range bits appear before the contact identifier, so we have to store their state for a short time).