Skip to content

xfs: more return cleanups

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfs: cleanup xfs_bmse_shift_one goto messfs/xfs/libxfs/xfs_bmap.c+17 -261 reply
2/2xfs: cleanup xfs_bmse_merge returnsfs/xfs/libxfs/xfs_bmap.c+8 -151 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBrian Foster
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] xfs: more return cleanups

Hi folks,

I noticed a bit of inconsistency when reviewing the shift extent return cleanups that coccinelle flagged. The first was that the out_error labels were basically meaningless - it jsut returns the error, and we have much neater ways of doing that. Also, the logic flow through xfs_bmse_shift_one() jumped around all over the place - it can be done lots neater without any gotos at all, and is easier to read as a result.

These patches apply on top of the for-next branch (the xfs-coccinelle-cleanups branch to be precise).

Cheers,

Dave.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs