Skip to content

i2c-designware: Add Intel Baytrail pmic i2c bus support

David E. Box linux-i2c lkml 2 versions – Applied

Status from this message: Applied to for-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 6 repliesApplied
  2. v32 patches 9 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2i2c-designware: Add i2c bus locking supportdrivers/i2c/busses/i2c-designware-core.c drivers/i2c/busses/i2c-designware-core.h+32 -01 reply
2/2i2c-designware: Add Intel Baytrail PMIC I2C bus supportdrivers/i2c/busses/Kconfig drivers/i2c/busses/Makefile drivers/i2c/busses/i2c-designware-baytrail.c +2 more+193 -54 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMika Westerberg
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 0/2] i2c-designware: Add Intel Baytrail pmic i2c bus support

V4: - Added bus lock to i2c_dw_init() as suggested by Jarrko Nikula
<jarkko.nikula-VuQAYsv1563Yd54FQh9/[email protected]>. Addresses infrequent hang that was seen occuring during probe.
- Added label in i2c_dw_xfer() to bypass unnecessary lock release when acquire fails. Suggested by Mika.
- Changed make to build driver as composite addition to i2c-designware-platform. Driver can be module or built-in following
the platform driver selection. Tested as both.
- Added EPROBE_DEFER return to baytrail definition of i2c_dw_eval_lock()
to defer probe if iosf_mbi driver (required for acquring bus lock) is
not available.

V3: - Split lock support and driver into separate patches
- Change module build to bool. Platforms running without this driver cannot perform critical functions such as charging. Furthermore attempts by other drivers to access the i2c bus without a lock will hang the platform.
- Replaced has_hw_lock flag with acquire/release function pointers.
- Replaced acquire/release ifdef code with single i2c_dw_eval_lock_support() test for cleaner (if still undesirable) compile time scalability. Future Intel platforms will however continue to use the Baytrail driver.

V2: - Moved semaphore detection out of dw platform driver
- Replaced function pointers with defined acquire/release functions in dw core. This helps eliminate the ifdefery in the dw platform driver.
- Use new has_hw_lock flag to check if the lock exists on a given bus.
- Use new pm_runtime_disabled flag to conditionally turnoff runtime pm in the dw platform driver.

David E. Box (2):
i2c-designware: Add i2c bus locking support
i2c-designware: Add Intel Baytrail PMIC I2C bus support

 drivers/i2c/busses/Kconfig                   |  11 ++
 drivers/i2c/busses/Makefile                  |   1 +
 drivers/i2c/busses/i2c-designware-baytrail.c | 160 +++++++++++++++++++++++++++
 drivers/i2c/busses/i2c-designware-core.c     |  26 +++++
 drivers/i2c/busses/i2c-designware-core.h     |  12 ++
 drivers/i2c/busses/i2c-designware-platdrv.c  |  20 +++-
 6 files changed, 225 insertions(+), 5 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-designware-baytrail.c
Signature · 1 line
1.9.1