Implement for driving libvirt via virsh
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest19 patches 19 repliesIn review
- v218 patches 42 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | TestSupport: Add helper to wait for a guest to shutdownOsstest/ | +18 | 1 reply | |
| 2/19 | apt: lock osstest's usages of apt-get against each otherOsstest/ Osstest/ | +6 | 1 reply | |
| 3/19 | ts-logs-capture: Collect some libvirt logs and capabilitiests-logs-capture | +4 | 0 replies | |
| 4/19 | Pass host to toolstack()Osstest/ ts-debian-fixup ts-debian-hvm-install +11 more | +34 | 0 replies | |
| 5/19 | ts-rumpuserxen-demo-xenstorels: Use standard functions for thingsts-rumpuserxen-demo-xenstorels | +2 | 0 replies | |
| 6/19 | Toolstack: use get_host_method_object() to manage toolstack selectionOsstest/ Osstest/ Osstest/ +1 more | +111 | 0 replies | |
| 7/19 | TestSupport: always use xl for generic operations.Osstest/ ts-debian-fixup | +12 | 3 replies | |
| 8/19 | TestSupport: guest_create and guest_destroy take only a $gho.Osstest/ ts-debian-hvm-install ts-guest-destroy +3 more | +16 | 1 reply | |
| 9/19 | Toolstack: Refactor guest lifecycle.Osstest/ Osstest/ Osstest/ +2 more | +37 | 1 reply | |
| 10/19 | Toolstack: Refactor consolecmd handlingOsstest/ Osstest/ ts-logs-capture | +13 | 1 reply | |
| 11/19 | Toolstack: Refactor shutdown supportOsstest/ Osstest/ ts-guest-stop | +14 | 1 reply | |
| 12/19 | Toolstack: Refactor migration support check.Osstest/ Osstest/ Osstest/ +1 more | +18 | 0 replies | |
| 13/19 | Toolstack: Refactor migration support.Osstest/ Osstest/ ts-guest-localmigrate +1 more | +18 | 1 reply | |
| 14/19 | Toolstack: Refactor save/restore supportOsstest/ Osstest/ ts-guest-saverestore | +31 | 1 reply | |
| 15/19 | libvirt: Implement initscript restart which has some hope of working.ts-libvirt-build | +15 | 1 reply | |
| 16/19 | libvirt: Implement shutdown_waitOsstest/ Osstest/ | +10 | 0 replies | |
| 17/19 | Toolstack: Remove Command field for all toolstacks.Osstest/ Osstest/ Osstest/ | +10 | 0 replies | |
| 18/19 | ts-guest-start: Use guest_createOsstest/ Osstest/ Osstest/ +1 more | +1 | 2 replies | |
| 19/19 | Toolstack: Pass $gho to create methodOsstest/ Osstest/ Osstest/ | +5 | 1 reply |
Reviews trailers per patch
All 19 patches have a Reviewed-by or Acked-by.
| Patch | Ian Jackson |
|---|---|
| 1/19 | A-b |
| 2/19 | A-b |
| 3/19 | A-b |
| 4/19 | A-b |
| 5/19 | A-b |
| 6/19 | A-b |
| 7/19 | A-b |
| 8/19 | A-b |
| 9/19 | A-b |
| 10/19 | A-b |
| 11/19 | A-b |
| 12/19 | A-b |
| 13/19 | A-b |
| 14/19 | A-b |
| 15/19 | A-b |
| 16/19 | A-b |
| 17/19 | A-b |
| 18/19 | A-b |
| 19/19 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 OSSTEST 0/19] Implement for driving libvirt via virsh
The following series switches osstest to implement the toolstack via get_host_method_object()->method rather than toolstack()->{Command}." method" etc.
This is needed because virsh differs from xm/xl in a few commands.
It also implements partial virsh support (simple lifecycle stuff, but not e.g. migration yet). Due to the ts-migration-check logic this means that the libvirt sequence works in so far as it skips/ignores the migration/save+restore related tests. Wei has a followup series (or at least a WIP?) which adds migration support. I've dropped my WIP patch from last time in favour of that.
Since last time I've addressed all of Ian's review on v2. Lots of passing $gho to things instead of individual properties, switch to a better inheritance scheme for Osstest::Toolstack::xend,
* TestSupport: Add helper to wait for a guest to shutdown
apt: lock osstest's usages of apt-get against each other
A ts-logs-capture: Collect some libvirt logs and capabilities
A Pass host to toolstack()
A ts-rumpuserxen-demo-xenstorels: Use standard functions for things
Toolstack: use get_host_method_object() to manage toolstack selection
TestSupport: always use xl for generic operations.
TestSupport: guest_create and guest_destroy take only a $gho.
Toolstack: Refactor guest lifecycle.
Toolstack: Refactor consolecmd handling
Toolstack: Refactor shutdown support
A Toolstack: Refactor migration support check.
Toolstack: Refactor migration support.
Toolstack: Refactor save/restore support
libvirt: Implement initscript restart which has some hope of working.
A libvirt: Implement shutdown_wait
A Toolstack: Remove Command field for all toolstacks.
A ts-guest-start: Use guest_create
N Toolstack: Pass $gho to create method
* == "TestSupport: Add helper to wait for a guest to shutdown") wasn't posted last time, it was actually part of the "add distro domU testing flight" series, but it is needed here too and I expect this one to land first.
N == New
A == Acked
Ian.