Skip to content

FBC improvements + frontbuffer tracking conversion

Paulo Zanoni intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/i915: Move FBC stuff to intel_fbc.cdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_suspend.c +5 more+698 -6690 replies
2/11drm/i915: Introduce FBC DocBook.Documentation/DocBook/drm.tmpl drivers/gpu/drm/i915/intel_fbc.c+54 -84 replies
3/11drm/i915: don't try to find crtcs for FBC if it's disableddrivers/gpu/drm/i915/intel_fbc.c+8 -122 replies
4/11drm/i915: don't keep reassigning FBC_UNSUPPORTEDdrivers/gpu/drm/i915/intel_fbc.c+2 -32 replies
5/11drm/i915: change dev_priv->fbc.plane to dev_priv->fbc.crtcdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_fbc.c +1 more+7 -81 reply
6/11drm/i915: pass which operation triggered the frontbuffer trackingdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_execbuffer.c +2 more+30 -153 replies
6/11drm/i915: pass which operation triggered the frontbuffer trackingdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_execbuffer.c +2 more+30 -150 replies
7/11drm/i915: also do frontbuffer tracking on pwritesdrivers/gpu/drm/i915/i915_gem.c+4 -03 replies
8/11drm/i915: add fronbuffer tracking to FBCdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_fbc.c +3 more+80 -1102 replies
8/11drm/i915: add frontbuffer tracking to FBCdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_fbc.c +3 more+80 -980 replies
9/11drm/i915: extract intel_fbc_find_crtc()drivers/gpu/drm/i915/intel_fbc.c+29 -171 reply
10/11drm/i915: HSW+ FBC is tied to pipe Adrivers/gpu/drm/i915/intel_fbc.c+16 -42 replies
11/11drm/i915: gen5+ can have FBC with multiple pipesdrivers/gpu/drm/i915/intel_fbc.c+4 -22 replies

Reviews trailers per patch

10 of 13 patches have a Reviewed-by or Acked-by.

PatchPRC QA PRTS (Patch Regression Test System Contact:Rodrigo Vivi
1/11
2/11
3/11R-b
4/11
5/11R-b
6/11R-b
6/11R-b
7/11R-b
8/11R-b R-b
8/11R-b R-b
9/11R-b
10/11R-b
11/11T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] FBC improvements + frontbuffer tracking conversion

From: Paulo Zanoni <[email protected]>

Hi

This series does some minor fixes to the FBC code and also ports it to use the new front buffer tracking infrastructure.

Patches 1-2 are the transition from intel_pm.c to intel_fbc.c. Rodrigo's point is that it's better to move to intel_fbc.c first because then it's going to be easier to bisect any changes introduced by the series, and I agree with him. Also, I don't think we're going to bisect any FBC changes that happened before this series anyway.

I tested this series both on IGT's kms_fbc_crc.c and on another set of tests that I wrote on my own (yes, NIH syndrome). I plan to move all the new tests that I wrote to kms_fbc_crc, but I still didn't do this and it will take some time.

With the series applied, HSW passes all the tests. I still see some FIFO underruns on my BDW machine - not introduced by the series - so I don't think we should enable FBC by default yet.

Thanks,
Paulo

Paulo Zanoni (9):
drm/i915: don't try to find crtcs for FBC if it's disabled drm/i915: don't keep reassigning FBC_UNSUPPORTED drm/i915: change dev_priv->fbc.plane to dev_priv->fbc.crtc drm/i915: pass which operation triggered the frontbuffer tracking drm/i915: also do frontbuffer tracking on pwrites drm/i915: add fronbuffer tracking to FBC
drm/i915: extract intel_fbc_find_crtc()
drm/i915: HSW+ FBC is tied to pipe A
drm/i915: gen5+ can have FBC with multiple pipes

Rodrigo Vivi (2):
drm/i915: Move FBC stuff to intel_fbc.c
drm/i915: Introduce FBC DocBook.

 Documentation/DocBook/drm.tmpl             |   5 +
 drivers/gpu/drm/i915/Makefile              |   1 +
 drivers/gpu/drm/i915/i915_drv.h            |  21 +-
 drivers/gpu/drm/i915/i915_gem.c            |  14 +-
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |   2 +-
 drivers/gpu/drm/i915/i915_suspend.c        |   2 +-
 drivers/gpu/drm/i915/intel_display.c       |  27 +-
 drivers/gpu/drm/i915/intel_drv.h           |  24 +-
 drivers/gpu/drm/i915/intel_fbc.c           | 758 +++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_frontbuffer.c   |  29 +-
 drivers/gpu/drm/i915/intel_pm.c            | 651 +------------------------
 drivers/gpu/drm/i915/intel_ringbuffer.c    |  41 +-
 drivers/gpu/drm/i915/intel_ringbuffer.h    |   1 -
 drivers/gpu/drm/i915/intel_sprite.c        |   6 +-
 14 files changed, 833 insertions(+), 749 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/intel_fbc.c
Signature · 6 lines
2.1.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Read the cover letter in its thread