Skip to content

ATAPI migration fix/hack

Dr. David Alan Gilbert (git) qemu-devel 1 version Applied

Status from this message: Thanks, applied all to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 12 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2Restore atapi_dma flag across migrationhw/ide/core.c+1 -01 reply
2/2atapi migration: Throw recoverable error to avoid recoveryhw/ide/atapi.c hw/ide/internal.h hw/ide/pci.c+30 -09 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJohn Snow
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] ATAPI migration fix/hack

From: "Dr. David Alan Gilbert" <[email protected]>

This pair of patches fixes a problem where IDE/ATAPI cdrom reads get lost/corrupted over migration.

The first of the patches (restore atapi_dma flag) is a simple fix that I think is safe; it no longer causes corruption in the case we saw, but does still trigger a long timeout.

The second is a hack; it throws a medium error causing the guest to retry the command in the case where migration happens just between the IDE/ATAPI command being submitted
and the bmdma being finished. This recovers a lot
faster than the timeout.

Only tried on Linux guests so far; I think it might be possible to replace both of these by reparsing the command buffer for ATAPI; I'm just not confident I know when that's safe to do, and I wanted to see how disgusted people were by the 2nd hack.

Dave

Dr. David Alan Gilbert (2):
Restore atapi_dma flag across migration
atapi migration: Throw recoverable error to avoid recovery

 hw/ide/atapi.c    | 17 +++++++++++++++++
 hw/ide/core.c     |  1 +
 hw/ide/internal.h |  2 ++
 hw/ide/pci.c      | 11 +++++++++++
 4 files changed, 31 insertions(+)
Signature · 1 line
2.1.0