Skip to content

bond: static analysis issues fix

Declan Doherty dpdk-dev 3 versions – Applied

Status from this message: Applied

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyApplied
  2. v21 patch 2 repliesSuperseded
  3. v11 patch 1 replySuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3bond: add bounds check before assigning active slave count valuelib/librte_pmd_bond/rte_eth_bond_api.c+4 -00 replies
2/3bond: fix pci_id_table allocation check in rte_eth_bond_createlib/librte_pmd_bond/rte_eth_bond_api.c+1 -10 replies
3/3bond: eth_dev parameter used before NULL check in mac_address_get/setlib/librte_pmd_bond/rte_eth_bond_pmd.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] bond: static analysis issues fix

-v3:
Split patches

-v2:
Incorporates Pawel's comments regarding assertion's check on activate_slave array indexing

Fixes for link bonding library identified by static analysis tool

- Overflow assert for active_slaves array in activate_slave function
- Allocation check of pci_id_table in rte_eth_bond_create
- Use of eth_dev pointer in mac_address_get/set before NULL check

Declan Doherty (3):
bond: add bounds check before assigning active slave count value
bond: fix pci_id_table allocation check in rte_eth_bond_create
bond: eth_dev parameter used before NULL check mac_address_get/set

 lib/librte_pmd_bond/rte_eth_bond_api.c | 6 +++++-
 lib/librte_pmd_bond/rte_eth_bond_pmd.c | 8 ++++----
 2 files changed, 9 insertions(+), 5 deletions(-)
Signature · 1 line
1.7.12.2