Skip to content

imx-drm: ipuv3-crtc: Implement mode_fixup

Steve Longerbeam dri-devel linux-fbdev lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 15 repliesIn review
  2. v16 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7gpu: ipu-di: Add ipu_di_adjust_videomode()drivers/gpu/ipu-v3/ipu-di.c include/video/imx-ipu-v3.h+31 -01 reply
2/7gpu: ipu-di: remove some non-functional codedrivers/gpu/ipu-v3/ipu-di.c+0 -60 replies
3/7drm_modes: add videomode_from_drm_display_modedrivers/gpu/drm/drm_modes.c include/drm/drm_modes.h+42 -03 replies
4/7imx-drm: ipuv3-crtc: Implement mode_fixupdrivers/gpu/drm/imx/ipuv3-crtc.c+12 -02 replies
5/7imx-drm: encoder prepare/mode_set must use adjusted modedrivers/gpu/drm/imx/imx-hdmi.c drivers/gpu/drm/imx/imx-ldb.c drivers/gpu/drm/imx/imx-tve.c +1 more+9 -90 replies
6/7gpu: ipu-v3: Use videomode in struct ipu_di_signal_cfgdrivers/gpu/drm/imx/ipuv3-crtc.c drivers/gpu/ipu-v3/ipu-di.c include/video/imx-ipu-v3.h+56 -780 replies
7/7gpu: ipu-di: Switch to DIV_ROUND_CLOSEST for DI clock divider calcdrivers/gpu/ipu-v3/ipu-di.c+3 -60 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchFabio Estevam
SeriesT-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] imx-drm: ipuv3-crtc: Implement mode_fixup

This patchset implements ->mode_fixup() in the imx ipuv3-crtc driver, using a new support function ipu_di_adjust_videomode(). This new function needs to be subsystem independent, so it accepts a video mode as a 'struct videomode'. Hence ipu-crtc ->mode_fixup() needs another support function to convert a drm_display_mode to a videomode before passing the mode to ipu_di_adjust_videomode() for fixup.

Also some related code cleanup: 'struct ipu_di_signal_cfg' should use 'struct videomode' for mode timings.

Jiada Wang (1):
gpu: ipu-di: Add ipu_di_adjust_videomode()

Steve Longerbeam (6):
gpu: ipu-di: remove some non-functional code
drm_modes: add videomode_from_drm_display_mode
imx-drm: ipuv3-crtc: Implement mode_fixup
imx-drm: encoder prepare/mode_set must use adjusted mode
gpu: ipu-v3: Use videomode in struct ipu_di_signal_cfg
gpu: ipu-di: Switch to DIV_ROUND_CLOSEST for DI clock divider calc

 drivers/gpu/drm/drm_modes.c            |   40 +++++++++++
 drivers/gpu/drm/imx/imx-hdmi.c         |    4 +-
 drivers/gpu/drm/imx/imx-ldb.c          |    6 +-
 drivers/gpu/drm/imx/imx-tve.c          |    4 +-
 drivers/gpu/drm/imx/ipuv3-crtc.c       |   38 +++++-----
 drivers/gpu/drm/imx/parallel-display.c |    4 +-
 drivers/gpu/ipu-v3/ipu-di.c            |  121 +++++++++++++++++++-------------
 include/drm/drm_modes.h                |    2 +
 include/video/imx-ipu-v3.h             |   21 ++----
 9 files changed, 147 insertions(+), 93 deletions(-)
Signature · 1 line
1.7.9.5