Fix bugs in kona pwm driver and pwm core
Status from this message: Applied, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Earlier versions · 9
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 | 5 patches | 3 replies | Superseded | |
| v6 | 4 patches | 4 replies | Superseded | |
| v5 posting 2/2 | 2 patches | 5 replies | Superseded | |
| v4 posting 2/2 | 2 patches | 2 replies | Superseded | |
| v3 | 2 patches | 4 replies | Superseded | |
| v5 posting 1/2 | 2 patches | 1 reply | Superseded | |
| v4 posting 1/2 | 3 patches | 2 replies | Superseded | |
| v2 | 2 patches | 16 replies | Superseded | |
| v1 | 2 patches | 3 replies | Superseded |
Changes in v10 from the cover letter
- pwm_set_polarity() enabled check is protected using the same mutex as pwm_enable() in pwm core. Implemented as suggested by Thierry.
Patches in v10 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | pwm: core: Set enable state properly on failed call to enabledrivers/ include/ | +28 | 1 reply |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Jonathan Richardson | Dmitry Torokhov |
|---|---|---|
| 1/1 | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v10 0/1] Fix bugs in kona pwm driver and pwm core
Fixes a bug in the pwm core where the enabled state was incorrect on failed calls to enable.
Changes from v9:
- pwm_set_polarity() enabled check is protected using the same mutex as pwm_enable() in pwm core. Implemented as suggested by Thierry.
Changes from v8:
- Accepted patches not included. Patch to introduce debug statements to config in kona pwm driver not included - will be addressed later.
- Added mutex to pwm core enable function to prevent potential concurrency issue, as suggested by Thierry.
- Fixed commit message for kona pwm changes. Also changed wording in comments from enable to trigger.
Changes from v7:
- Polarity changes take effect immediately instead of being deferred until enable is called.
Changes from v6:
- Move new debugging info for duty cycle and period in config function into its own commit.
- Add kona_pwmc_prepare_for_settings() function to remove duplicated code.
Changes from v5:
- Address Dmitry's comment on code cleanup of pwm_enable() in pwm core.
- Including all patches from different contributors in this patchset. Some were left out in v4.
Changes from v4:
- Rebased to Tim Kryger's patch that adds support in pwm core to add driver with inversed polarity.
- Removed patch 2 that resolved difference between hardware default polarity and pwm framework default polarity. The default polarity is set properly now when the pwm driver is registered with the pwm framework.
Jonathan Richardson (1):
pwm: core: Set enable state properly on failed call to enable
drivers/pwm/core.c | 33 ++++++++++++++++++++++++++------- include/linux/pwm.h | 2 ++ 2 files changed, 28 insertions(+), 7 deletions(-)
Signature · 1 line
1.9.1