RFC USB: input: yealink.c: update key mappings
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | USB: input: yealink.c: use KEY_NUMERIC_* for numeric keys, star and pounddrivers/ | +15 | 1 reply | |
| 2/2 | USB: input: yealink.c: add mapping for "RING" and "MUTE" keysdrivers/ | +4 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/2] USB: input: yealink.c: update key mappings
Hello,
I have an Yealink USB phone which is handled by the yealink.c driver but the '#' key returns an unexpected value and keys labeled "RING" and "MUTE" do not return any value to userspace.
In the first patch of this series I replace the combination KEY_LEFTSHIFT and KEY_3 with KEY_NUMERIC_POUND and I also replace other keys for internal consistency and with the cm109.c driver, which according to the comment in the code is derived from this one, is this the right approach?
In the second patch I add two additional keys which could be handled by userspace:
"RING" whose purpose according to the user manual is to cycle all available ringtones "MUTE" whose purpose is to mute the USB microphone
which KEY_* values should be used for them?
I have two more questions:DRIVER_VERSION should be updated?
are both patches suitable for stable?
Daniele Forsi (2):
USB: input: yealink.c: use KEY_NUMERIC_* for numeric keys, star and
pound
USB: input: yealink.c: add mapping for "RING" and "MUTE" keys
drivers/input/misc/yealink.c | 43 +++++++++++++++++++------------------------ 1 file changed, 19 insertions(+), 24 deletions(-)
Signature · 1 line
2.1.3