More simple FBC fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | drm/i915: don't reallocate the compressed FB at every framedrivers/ | +1 | 0 replies | |
| 2/9 | drm/i915: fix the FBC CFB size trackingdrivers/ drivers/ drivers/ | +6 | 3 replies | |
| 3/9 | drm/i915: don't increment the FBC threshold at fbc_enabledrivers/ | +6 | 0 replies | |
| 4/9 | drm/i915: don't free the CFB while FBC is enableddrivers/ drivers/ | +10 | 3 replies | |
| 5/9 | drm/i915: don't set the FBC plane select bits on HSW+drivers/ | +5 | 1 reply | |
| 6/9 | drm/i915: add the FBC mutexdrivers/ drivers/ | +64 | 2 replies | |
| 7/9 | drm/i915: don't alloc/free fbc_work at every updatedrivers/ drivers/ | +17 | 2 replies | |
| 8/9 | drm/i915: print FBC compression status on debugfsdrivers/ drivers/ | +8 | 0 replies | |
| 9/9 | drm/i915: FBC only supports 16bpp and 32bppdrivers/ | +9 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/9] More simple FBC fixes
From: Paulo Zanoni <[email protected]>
Hi
Since the previous FBC series is already entirely reviewed, it's time to submit a few more FBC patches to the mailing list. These patches just fix some simple bugs and annoyances: nothing really major. I tested them on my BDW and they pass the tests I have.
In theory we could even think about maybe enabling FBC on HSW+ since I can't think of any bugs remaining on these platforms. The biggest reason to prevent that is that I still didn't upstream the FBC tests I wrote since I still didn't integrate them to kms_fbc_crc - which I'm also running.
This doesn't mean FBC's TODO list is empty: there are still a lot of small improvements to do, and one of them is to _not_ disable FBC during page flips. I also didn't really do any power or performance tests yet: the focus is completely on bugs.
Regarding the previous platforms, I think there could be some hope to support FBC on ILK+, but I'm really only focused on HSW+, so I don't know if we're missing some checks and restrictions. For the older platforms, I think that, given all the conditions, the risk of enabling FBC and breaking these platforms even more is probably not worth it.
Thanks,
Paulo
Paulo Zanoni (9):
drm/i915: don't reallocate the compressed FB at every frame drm/i915: fix the FBC CFB size tracking
drm/i915: don't increment the FBC threshold at fbc_enable drm/i915: don't free the CFB while FBC is enabled drm/i915: don't set the FBC plane select bits on HSW+ drm/i915: add the FBC mutex
drm/i915: don't alloc/free fbc_work at every update drm/i915: print FBC compression status on debugfs drm/i915: FBC only supports 16bpp and 32bpp
drivers/gpu/drm/i915/i915_debugfs.c | 5 + drivers/gpu/drm/i915/i915_drv.h | 5 +- drivers/gpu/drm/i915/i915_gem_stolen.c | 16 ++-- drivers/gpu/drm/i915/i915_reg.h | 3 + drivers/gpu/drm/i915/intel_fbc.c | 161 +++++++++++++++++++++------------ 5 files changed, 123 insertions(+), 67 deletions(-)
Signature · 6 lines
2.1.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx