Remove use of gdata for global_data
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 of 9 patches 0 repliesNew
2 of 9 patches are in this archive. The cover letter announces 9.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 2/9 | sunxi: Move SPL s_init() code to board_init_f() | +0 | 13 replies | |
| 3/9 | sunxi: Drop use of lowlevel_init() | +0 | 0 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Ian Campbell |
|---|---|
| 2/9 | |
| 3/9 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH 0/9] Remove use of gdata for global_data
Quoted 14 lines · Simon Glass
Some ARM boards use
global_datain SPL before it set up bycrt0.S. To achieve this they use a separateglobal_datavariable called gdata which resides in the data section. The one set up bycrt0.Sis generally ignored.This prevents
crt0.Sfrom setting up things like the earlymalloc()pool. It therefore prevents driver model from being used in SPL.However gdata really isn't needed. In fact
lowlevel_init()is called just beforeboard_init_f()so, for SPL at least, there is no point in doing anything beforeboard_init_f(). The one slightly messy area is that SPL may want to move the stack from SRAM to SDRAM at some point. But this should be done at the end ofboard_init_f()(or beforeboard_init_r()is called) and is not a reason to init DRAM beforeboard_init_f().
Quoted 5 lines
It isn't that difficult to get rid of gdata. This series builds on Tom Rini's recent series for omap3, and extends it to the other offenders: imx, sunxi and zynq.
I have tested so far only on sunxi.
Did you test both FEL and regular mode? (IOW, to what extent do I need to refresh my memory on the differences between the two...)
Quoted 27 lines
This series is available at u-boot-dm
branch 'gd-working'.Simon Glass (9):
arm: Add warnings about using gdata
sunxi: Move SPLs_init()code toboard_init_f()
sunxi: Drop use oflowlevel_init()
arm: Reduce the scope oflowlevel_init()
zynq: Remove reference to gdata
imx:cm_fx6: Remove reference to gdata
imx: woodburn: Remove reference to gdata
imx: ls102xa: Remove reference to gdata
arm: Drop gdataglobal_datavariable in SPLarch/arm/cpu/armv7/lowlevel_init.S | 23 +++++++----- arch/arm/cpu/armv7/sunxi/board.c | 66 ++++++++++++++++----------------- arch/arm/cpu/armv7/zynq/spl.c | 3 -- arch/arm/include/asm/spl.h | 2 - arch/arm/lib/spl.c | 11 +++--- board/compulab/cm_fx6/spl.c | 1 - board/freescale/ls1021aqds/ls1021aqds.c | 3 -- board/freescale/ls1021atwr/ls1021atwr.c | 3 -- board/woodburn/woodburn.c | 3 -- include/configs/sunxi-common.h | 1 + 10 files changed, 53 insertions(+), 63 deletions(-)