Skip to content

ARM: Add support for a generic PCI Express host bridge

Alexander Graf qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 4 repliesIn review
  2. v44 patches 4 repliesSuperseded
  3. v34 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches19 repliesSuperseded
v14 patches39 repliesSuperseded

Changes in v5 from the cover letter

- fix size alignment calculation
- expose bus-range as 16
- improve mmio map comment

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4pci: Allocate PCIe host bridge PCI IDinclude/hw/pci/pci.h+1 -00 replies
2/4pci: Add generic PCIe host bridgehw/pci-host/Makefile.objs hw/pci-host/gpex.c include/hw/pci-host/gpex.h+211 -00 replies
3/4arm: Add PCIe host bridge in virt machinedefault-configs/arm-softmmu.mak hw/arm/virt.c include/sysemu/device_tree.h+143 -53 replies
4/4pci: Move PCI VGA to pci.makdefault-configs/alpha-softmmu.mak default-configs/i386-softmmu.mak default-configs/mips-softmmu.mak +9 more+2 -220 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchClaudio Fontana
1/4
2/4R-b T-b
3/4T-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Qemu-devel] [PATCH v5 0/4] ARM: Add support for a generic PCI Express host bridge

Linux implements a nice binding to describe a "generic" PCI Express host bridge using only device tree.

This patch set adds enough emulation logic to expose the parts that are "generic" as a simple sysbus device and maps it into ARM's virt machine.

With this patch set, we can finally spawn PCI devices on ARM VMs. I was able to have a fully DRM enabled virtual machine with VGA, e1000 and XHCI (for keyboard and mouse) up and working.

It's only a small step for QEMU, but a big step for ARM VM's usability.

v1 -> v2:

- Add documentation links
- Remove mmio_window_size
- Add define for pci range types
- Use 4 PCI INTX IRQ lines

v2 -> v3:

- Update patch description
- Increase ecam region to full size
- Expose number of irqs via define
- Update header description
- Update host bridge qom description string
- Use new Red Hat PCIe host bridge PCI ID
- Coding style fixes
- Map ECAM space via alias to limit its size
- Increase ECAM size to 16 buses
- Use GPEX IRQ number define
- Align ECAM region, Document region allocation better
- Move interrupt-map into irq map function
- s/FDT_PCI_RANGE_TYPE/FDT_PCI_RANGE_TYPE_MASK/

v3 -> v4:

- update memory map comment

v4 -> v5:

- fix size alignment calculation
- expose bus-range as 16
- improve mmio map comment

Alexander Graf (4):
pci: Allocate PCIe host bridge PCI ID
pci: Add generic PCIe host bridge
arm: Add PCIe host bridge in virt machine
pci: Move PCI VGA to pci.mak

 default-configs/alpha-softmmu.mak    |   2 -
 default-configs/arm-softmmu.mak      |   2 +
 default-configs/i386-softmmu.mak     |   2 -
 default-configs/mips-softmmu.mak     |   2 -
 default-configs/mips64-softmmu.mak   |   2 -
 default-configs/mips64el-softmmu.mak |   2 -
 default-configs/mipsel-softmmu.mak   |   2 -
 default-configs/pci.mak              |   2 +
 default-configs/ppc-softmmu.mak      |   2 -
 default-configs/ppc64-softmmu.mak    |   2 -
 default-configs/ppcemb-softmmu.mak   |   2 -
 default-configs/sparc64-softmmu.mak  |   2 -
 default-configs/x86_64-softmmu.mak   |   2 -
 hw/arm/virt.c                        | 137 +++++++++++++++++++++++++++++--
 hw/pci-host/Makefile.objs            |   1 +
 hw/pci-host/gpex.c                   | 154 +++++++++++++++++++++++++++++++++++
 include/hw/pci-host/gpex.h           |  56 +++++++++++++
 include/hw/pci/pci.h                 |   1 +
 include/sysemu/device_tree.h         |   9 ++
 19 files changed, 357 insertions(+), 27 deletions(-)
 create mode 100644 hw/pci-host/gpex.c
 create mode 100644 include/hw/pci-host/gpex.h
Signature · 1 line
1.7.12.4