Skip to content

xfsprogs/repair: secondary sb scan cleanups

Brian Foster linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2repair: fix unnecessary secondary scan if only last sb is corruptrepair/sb.c+2 -22 replies
2/2repair: remove unused strided secondary sb scan logicrepair/globals.h repair/sb.c+20 -451 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchEric Sandeen
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] xfsprogs/repair: secondary sb scan cleanups

Hi all,

Here are a couple patches to clean up the secondary sb scanning in phase 1 of xfs_repair. Patch 1 is a fix for a bug encountered by a user with a corrupted fs/array that lead to scattered sb corruption:

http://oss.sgi.com/archives/xfs/2015-01/msg00113.html

Patch 2 is a larger cleanup of the affected sb scan function after reading through the code and not being able to grok the need for some of the extra complexity therein. I don't think it should affect behavior much, but thoughts appreciated.

Brian

Brian Foster (2):
repair: fix unnecessary secondary scan if only last sb is corrupt
repair: remove unused strided secondary sb scan logic

 repair/globals.h |  2 --
 repair/sb.c      | 67 +++++++++++++++++++-------------------------------------
 2 files changed, 22 insertions(+), 47 deletions(-)
Signature · 6 lines
1.8.3.1

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs