Skip to content

unified flow types and RSS offload types

Helin Zhang dpdk-dev 2 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 4 repliesApplied
  2. v17 patches 6 repliesSuperseded

Changes in v2 from the cover letter

* Integrated with configuring hash functions.
* Corrected the wrong help string of flow director parameters.
* Renamed the flow types from ETH_FLOW_TYPE_ to RTE_ETH_FLOW_.
* Removed useless annotations for flow type elements in rte_eth_ctrl.h.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7app/test-pmd: code style fixapp/test-pmd/config.c+3 -30 replies
2/7ethdev: code style fixlib/librte_ether/rte_eth_ctrl.h+16 -160 replies
3/7i40e: code style fixlib/librte_pmd_i40e/i40e_fdir.c+2 -50 replies
4/7ethdev: fix of calculating the size of flow type mask arraylib/librte_ether/rte_eth_ctrl.h+5 -20 replies
5/7ethdev: unification of flow typesapp/test-pmd/cmdline.c app/test-pmd/config.c lib/librte_ether/rte_eth_ctrl.h +3 more+287 -2100 replies
6/7ethdev: unification of RSS offload typesapp/test-pipeline/init.c app/test-pmd/config.c examples/distributor/main.c +15 more+198 -1990 replies
7/7app/testpmd: support new rss offloadsapp/test-pmd/cmdline.c+15 -40 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJingjing Wu
SeriesA-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] unified flow types and RSS offload types

It unifies the flow types and RSS offload types for all PMDs. Previously flow types are defined specifically for i40e, and there has different RSS offloads tyeps for 1/10G and 40G seperately. This is not so convenient for application development, and not good for adding new PMDs. In addition, it enables new RSS offloads of 'tcp' and 'all' in testpmd.

v2 changes:
* Integrated with configuring hash functions.
* Corrected the wrong help string of flow director parameters.
* Renamed the flow types from ETH_FLOW_TYPE_ to RTE_ETH_FLOW_.
* Removed useless annotations for flow type elements in rte_eth_ctrl.h.

Helin Zhang (7):
app/test-pmd: code style fix
ethdev: code style fix
i40e: code style fix
ethdev: fix of calculating the size of flow type mask array
ethdev: unification of flow types
ethdev: unification of RSS offload types app/testpmd: support new rss offloads

 app/test-pipeline/init.c                |   2 +-
 app/test-pmd/cmdline.c                  | 154 +++++++++++++++++++-----------
 app/test-pmd/config.c                   | 137 +++++++++++++++++---------
 examples/distributor/main.c             |   9 +-
 examples/ip_pipeline/init.c             |   2 +-
 examples/l3fwd-acl/main.c               |   7 +-
 lib/librte_ether/rte_eth_ctrl.h         |  94 ++++++++++--------
 lib/librte_ether/rte_ethdev.h           | 147 ++++++++++++----------------
 lib/librte_pmd_e1000/e1000_ethdev.h     |  11 +++
 lib/librte_pmd_e1000/igb_ethdev.c       |   1 +
 lib/librte_pmd_e1000/igb_rxtx.c         |  27 ++----
 lib/librte_pmd_i40e/i40e_ethdev.c       | 164 +++++++++++++++++---------------
 lib/librte_pmd_i40e/i40e_ethdev.h       |  52 +++++-----
 lib/librte_pmd_i40e/i40e_ethdev_vf.c    |   1 +
 lib/librte_pmd_i40e/i40e_fdir.c         |  99 ++++++++++---------
 lib/librte_pmd_ixgbe/ixgbe_ethdev.c     |   1 +
 lib/librte_pmd_ixgbe/ixgbe_ethdev.h     |  11 +++
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c       |  27 ++----
 lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c |   1 +
 lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h |   6 ++
 lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c   |  10 +-
 21 files changed, 525 insertions(+), 438 deletions(-)
Signature · 1 line
1.9.3