Skip to content

isa: remove isa_mem_base variable

Hervé Poussineau qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 2 repliesIn review
  2. v17 patches 1 replySuperseded

Changes in v2 from the cover letter

- correctly handle PCI0 windows in gt64xxx

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7isa: add memory space parameter to isa_bus_newhw/alpha/typhoon.c hw/i386/pc_piix.c hw/isa/i82378.c +9 more+26 -140 replies
2/7jazz: do not explode QEMUMachineInitArgs structurehw/mips/mips_jazz.c+8 -130 replies
3/7jazz: remove usage of isa_mem_basehw/mips/mips_jazz.c+14 -110 replies
4/7mips: remove isa_mem_base usagehw/mips/mips_r4k.c+10 -90 replies
5/7piix4: use PCI address space instead of system memoryhw/isa/piix4.c+1 -10 replies
6/7gt64xxx: remove isa_mem_base usagehw/mips/gt64xxx_pci.c+68 -270 replies
7/7isa: remove isa_mem_base variablehw/display/cirrus_vga.c hw/display/vga-isa.c hw/display/vga.c +2 more+3 -70 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchPaolo BonziniMark Cave-Ayland
SeriesT-b
1/7R-b
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/7] isa: remove isa_mem_base variable

Hi,

This patchset removes the isa_mem_base variable in VGA display devices. This variable is a global variable telling at which address is the ISA memory base address in the system memory address space.

Once removed, we're paving the way to new QEMU functionalities:
- supporting other MMIO ISA devices (like some network cards)
- supporting multiple ISA buses (not done in this patchset)

Most of the changes are MIPS-related, so maybe Aurélien or Leon can take care of them?

Changes since v1:
- correctly handle PCI0 windows in gt64xxx

Hervé Poussineau (7):
isa: add memory space parameter to isa_bus_new
jazz: do not explode QEMUMachineInitArgs structure
jazz: remove usage of isa_mem_base
mips: remove isa_mem_base usage
piix4: use PCI address space instead of system memory
gt64xxx: remove isa_mem_base usage
isa: remove isa_mem_base variable

 hw/alpha/typhoon.c      |    2 +-
 hw/display/cirrus_vga.c |    2 +-
 hw/display/vga-isa.c    |    2 +-
 hw/display/vga.c        |    3 +-
 hw/i386/pc_piix.c       |    2 +-
 hw/isa/i82378.c         |    3 +-
 hw/isa/isa-bus.c        |   12 ++++--
 hw/isa/lpc_ich9.c       |    2 +-
 hw/isa/piix4.c          |    3 +-
 hw/isa/vt82c686.c       |    3 +-
 hw/mips/gt64xxx_pci.c   |   95 +++++++++++++++++++++++++++++++++--------------
 hw/mips/mips_jazz.c     |   44 +++++++++++-----------
 hw/mips/mips_r4k.c      |   19 +++++-----
 hw/pci-host/piix.c      |    3 +-
 hw/sparc64/sun4u.c      |    3 +-
 include/hw/isa/isa.h    |    6 +--
 16 files changed, 126 insertions(+), 78 deletions(-)
Signature · 1 line
1.7.10.4