Skip to content

timer/m48t59: QOM'ify

Hervé Poussineau qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4m48t59: move ISA ports/memory regions registration to QOM constructorhw/timer/m48t59.c+13 -120 replies
2/4m48t59: register a QOM type for each nvram type we supporthw/timer/m48t59.c+169 -770 replies
3/4m48t59: add a Nvram interfacehw/timer/m48t59.c include/hw/timer/m48t59.h+83 -00 replies
4/4m48t59: let init functions return a Nvram objecthw/ppc/ppc.c hw/ppc/prep.c hw/sparc/sun4m.c +3 more+177 -2310 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMark Cave-AylandAlexander Graf
SeriesT-b A-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/4] timer/m48t59: QOM'ify

Hi,

This patchset QOM'ifies the m48t59 timer.
Patch 1 allows the creation of the m4859 ISA device from the command line. Patch 2 QOM'ifies the device.
Patches 3 add a Nvram interface to m48txx devices, so that callers can detect the device and use it without knowing m48txx internals. Patch 4 is using this new Nvram interface and cleaning the m48t59 header.

Patches 3 and 4 are not needed for m48t59 QOM'ification, but are in my opinion a nice cleanup.

Hervé Poussineau (4):
m48t59: move ISA ports/memory regions registration to QOM constructor
m48t59: register a QOM type for each nvram type we support
m48t59: add a Nvram interface
m48t59: let init functions return a Nvram object

 hw/ppc/ppc.c              |  161 ----------------------
 hw/ppc/prep.c             |  161 ++++++++++++++++++++--
 hw/sparc/sun4m.c          |    8 +-
 hw/sparc64/sun4u.c        |   10 +-
 hw/timer/m48t59.c         |  336 ++++++++++++++++++++++++++++++++-------------
 include/hw/timer/m48t59.h |   60 ++++----
 6 files changed, 429 insertions(+), 307 deletions(-)
Signature · 1 line
1.7.10.4