Add support for passthru cards to libcacard
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 12 repliesIn review
- v24 patches 1 replySuperseded
Changes in v3 from the cover letter
* Include outstanding patches not strictly related to passthru mode
* Include a fix for read binary transactions
* Mitigate some performance issues arising from libpccslite's heavy handed thread safety code
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | Bug fix: delete the reader entry after queueing an event, not before.libcacard/ | +1 | 1 reply | |
| 2/7 | Retrieve the correct TD byte when checking an ATR.hw/ | +1 | 1 reply | |
| 3/7 | Add a configure check for libpcsclite, and an option to enable or disable it.configure | +38 | 1 reply | |
| 4/7 | Add error checking to vcard_emul_options.libcacard/ | +38 | 1 reply | |
| 5/7 | Add a VCARD_DIRECT implemention to the libcacard smartcard support.Makefile.objs libcacard/ libcacard/ +3 more | +527 | 1 reply | |
| 6/7 | Enable support for passthru (e.g. direct to pcsc) smart cards in the emul_options entry point in libcacard.libcacard/ libcacard/ libcacard/ +1 more | +32 | 1 reply | |
| 7/7 | Remove the (broken) passthru option.libcacard/ | +3 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Marc-André Lureau |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard
This is a resend of my outstanding patches, gathered together as one series. I'm hoping to agitate for this whole set to be considered.
Changes since v2:
* Include outstanding patches not strictly related to passthru mode
* Include a fix for read binary transactions
* Mitigate some performance issues arising from libpccslite's heavy handed thread safety code
Jeremy White (7):
Bug fix: delete the reader entry after queueing an event, not before. Retrieve the correct TD byte when checking an ATR.
Add a configure check for libpcsclite, and an option to enable or
disable it.
Add error checking to vcard_emul_options.
Add a VCARD_DIRECT implemention to the libcacard smartcard support.
Enable support for passthru (e.g. direct to pcsc) smart cards in
the emul_options entry point in libcacard.
Remove the (broken) passthru option.
Makefile.objs | 5 + configure | 38 ++++ hw/usb/ccid-card-passthru.c | 2 +- libcacard/capcsc.c | 498 +++++++++++++++++++++++++++++++++++++++++++ libcacard/capcsc.h | 18 ++ libcacard/card_7816.c | 2 +- libcacard/card_7816.h | 3 + libcacard/libcacard.syms | 2 + libcacard/vcard.c | 2 +- libcacard/vcard.h | 2 +- libcacard/vcard_emul_nss.c | 78 +++++-- libcacard/vcard_emul_type.c | 3 +- libcacard/vreader.c | 2 +- libcacard/vscclient.c | 16 +- 14 files changed, 640 insertions(+), 31 deletions(-) create mode 100644 libcacard/capcsc.c create mode 100644 libcacard/capcsc.h
Signature · 1 line
1.7.10.4