xfs: buffer types need to be set
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | xfs: ensure buffer types are set correctlyfs/ | +4 | 1 reply | |
| 2/3 | xfs: inode unlink does not set AGI buffer typefs/ | +2 | 1 reply | |
| 3/3 | xfs: set buf types when converting extent formatsfs/ fs/ | +7 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Brian Foster |
|---|---|
| Series | R-b |
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] xfs: buffer types need to be set
Hi Jan,
These three patches detect and fix the issues you reported with log recovery finding buffers with a format type of zero. The type of zero (XFS_BLFT_UNKNOWN_BUF) is only valid for buffers that have been cancelled (i.e. invalidated or marked stale as they have been freed), so the series adds asserts to ensure these conditions are met during transaction commit. Hence we shouldn't ever get new code that fails to set the buffer type getting through testing.
The last two patches fix the cases that running xfstests uncovered where we don't set the buffer type appropriately. There may be more, but doing this much made my head hurt and xfstests is clean, so it's as much as I'm going to do right now. Can you test it and see if it runs clean (with CONFIG_XFS_WARN=y or CONFIG_XFS_DEBUG=y) on your test setup?
Cheers,
Dave.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs