support multi-pthread per core
Status from this message: Applied, thanks
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest19 patches 3 repliesApplied
- v719 patches 3 repliesSuperseded
- v619 patches 20 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 19 patches | 7 replies | Superseded | |
| v4 | 17 patches | 58 replies | Superseded | |
| v3 | 16 patches | 0 replies | Superseded | |
| v2 | 15 patches | 0 replies | Superseded | |
| v1 | 15 patches | 16 replies | Superseded |
Changes in v8 from the cover letter
keep using strlen for trusted input string
Patches in v8 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | eal: add cpuset into per EAL thread lcore_configlib/ lib/ lib/ +1 more | +24 | 0 replies | |
| 2/19 | eal: fix PAGE_SIZE redefine complaint on freebsdlib/ | +5 | 0 replies | |
| 3/19 | eal: new eal option '--lcores' for cpu assignmentlib/ lib/ lib/ | +303 | 0 replies | |
| 4/19 | eal: fix wrong strnlen() return value in 32bit icclib/ | +3 | 0 replies | |
| 5/19 | eal: add public function parsing socket_id from cpu_idlib/ lib/ lib/ | +22 | 0 replies | |
| 6/19 | eal: new TLS definition and API declarationlib/ lib/ lib/ +3 more | +69 | 0 replies | |
| 7/19 | eal: add eal_common_thread.c for common thread APIlib/ lib/ lib/ | +153 | 0 replies | |
| 8/19 | eal: standardize init sequence between linux and bsdlib/ | +2 | 0 replies | |
| 9/19 | eal: add rte_gettid() to acquire unique system tidlib/ lib/ lib/ | +43 | 0 replies | |
| 10/19 | eal: apply affinity of EAL thread by assigned cpusetlib/ lib/ lib/ +2 more | +37 | 0 replies | |
| 11/19 | enic: fix re-define freebsd compile complainlib/ lib/ lib/ | +6 | 0 replies | |
| 12/19 | malloc: fix the issue of SOCKET_ID_ANYlib/ | +6 | 0 replies | |
| 13/19 | log: fix the gap to support non-EAL threadlib/ lib/ | +20 | 0 replies | |
| 14/19 | eal: set _lcore_id and _socket_id to (-1) by defaultlib/ lib/ lib/ | +6 | 0 replies | |
| 15/19 | eal: fix recursive spinlock in non-EAL thraedlib/ | +2 | 0 replies | |
| 16/19 | mempool: add support to non-EAL threadlib/ | +11 | 0 replies | |
| 17/19 | ring: add support to non-EAL threadlib/ | +6 | 0 replies | |
| 18/19 | ring: add sched_yield to avoid spin foreverconfig/ config/ lib/ | +29 | 0 replies | |
| 19/19 | timer: add support to non-EAL threadlib/ lib/ | +25 | 0 replies |
Reviews trailers per patch
None of the 19 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Konstantin Ananyev |
|---|---|
| Series | A-b |
| 1/19 | |
| 2/19 | |
| 3/19 | |
| 4/19 | |
| 5/19 | |
| 6/19 | |
| 7/19 | |
| 8/19 | |
| 9/19 | |
| 10/19 | |
| 11/19 | |
| 12/19 | |
| 13/19 | |
| 14/19 | |
| 15/19 | |
| 16/19 | |
| 17/19 | |
| 18/19 | |
| 19/19 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v8 00/19] support multi-pthread per core
v8 changes:
keep using strlen for trusted input string
v7 changes:
update EAL version map for new public EAL API rollback to use strnlen() passing EAL core option
v6 changes:
rename RTE_RING_PAUSE_REP(_COUNT) and set default to 0 rollback to use RTE_MAX_LCORE when checking valid lcore_id for EAL thread
v5 changes:
reorder some patch and split into addtional two patches rte_thread_get_affinity() return type change to avoid add RTE_RING_PAUSE_REP into config and by default turn off
v4 changes:
new patch fixing strnlen() invalid return in 32bit icc [03/17] update and add more comments on sched_yield() [16/17]
v3 changes:
new patch adding sched_yield() in rte_ring to avoid long spin [16/17]
v2 changes:
add '<number>-<number>' support for EAL option '--lcores' [02/17]
The patch series contain the enhancements of EAL and fixes for libraries
to run multi-pthreads(either EAL or non-EAL thread) per physical core.
Two major changes list as below:
- Extend the core affinity of each EAL thread to 1:n.
Each lcore stands for a EAL thread rather than a logical core.
The change adds new EAL option to allow static lcore to cpuset assginment. Then a lcore(EAL thread) affinity to a cpuset, original 1:1 mapping is the special case.
- Fix the libraries to allow running on any non-EAL thread.
It fix the gaps running libraries in non-EAL thread(dynamic created by user). Each fix libraries take care the case of rte_lcore_id() >= RTE_MAX_LCORE.
Thanks a million for the comments from Konstantin, Bruce, Mirek and Stephen in RFC review.
Cunming Liang (19):
eal: add cpuset into per EAL thread lcore_config
eal: fix PAGE_SIZE redefine complaint on freebsd
eal: new eal option '--lcores' for cpu assignment
eal: fix wrong strnlen() return value in 32bit icc
eal: add public function parsing socket_id from cpu_id
eal: new TLS definition and API declaration
eal: add eal_common_thread.c for common thread API
eal: standardize init sequence between linux and bsd
eal: add rte_gettid() to acquire unique system tid
eal: apply affinity of EAL thread by assigned cpuset
enic: fix re-define freebsd compile complain
malloc: fix the issue of SOCKET_ID_ANY
log: fix the gap to support non-EAL thread
eal: set _lcore_id and _socket_id to (-1) by default
eal: fix recursive spinlock in non-EAL thraed
mempool: add support to non-EAL thread
ring: add support to non-EAL thread
ring: add sched_yield to avoid spin forever
timer: add support to non-EAL thread
config/common_bsdapp | 1 + config/common_linuxapp | 1 + lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal.c | 14 +- lib/librte_eal/bsdapp/eal/eal_lcore.c | 14 + lib/librte_eal/bsdapp/eal/eal_memory.c | 8 +- lib/librte_eal/bsdapp/eal/eal_thread.c | 77 ++---- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 + lib/librte_eal/common/eal_common_log.c | 17 +- lib/librte_eal/common/eal_common_options.c | 308 ++++++++++++++++++++- lib/librte_eal/common/eal_common_thread.c | 150 ++++++++++ lib/librte_eal/common/eal_options.h | 2 + lib/librte_eal/common/eal_thread.h | 47 ++++ .../common/include/generic/rte_spinlock.h | 4 +- lib/librte_eal/common/include/rte_eal.h | 27 ++ lib/librte_eal/common/include/rte_lcore.h | 40 ++- lib/librte_eal/common/include/rte_log.h | 5 + lib/librte_eal/linuxapp/eal/Makefile | 4 + lib/librte_eal/linuxapp/eal/eal.c | 8 +- lib/librte_eal/linuxapp/eal/eal_lcore.c | 15 +- lib/librte_eal/linuxapp/eal/eal_thread.c | 77 ++---- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 + lib/librte_malloc/malloc_heap.h | 7 +- lib/librte_mempool/rte_mempool.h | 18 +- lib/librte_pmd_enic/enic.h | 4 +- lib/librte_pmd_enic/enic_compat.h | 2 +- lib/librte_pmd_enic/vnic/vnic_dev.c | 6 +- lib/librte_ring/rte_ring.h | 41 ++- lib/librte_timer/rte_timer.c | 32 ++- lib/librte_timer/rte_timer.h | 4 +- 30 files changed, 769 insertions(+), 169 deletions(-) create mode 100644 lib/librte_eal/common/eal_common_thread.c
Signature · 1 line
1.8.1.4