Skip to content

unified packet type

Helin Zhang dpdk-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest18 patches 6 repliesIn review
  2. v316 patches 8 repliesSuperseded
  3. v215 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v117 patches21 repliesSuperseded

Changes in v4 from the cover letter

* Added detailed description of each packet types.
* Supported unified packet type of fm10k.
* Added printing logs of packet types of each received packet for rxonly mode in testpmd.
* Removed several useless code lines which block packet type unification from app/test/packet_burst_generator.c.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18mbuf: redefinition of packet_type in rte_mbufconfig/common_linuxapp lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h lib/librte_mbuf/rte_mbuf.h+19 -104 replies
2/18ixgbe: support of unified packet type for vectorconfig/common_linuxapp lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c+27 -240 replies
3/18mbuf: add definitions of unified packet typeslib/librte_mbuf/rte_mbuf.h+253 -01 reply
4/18e1000: support of unified packet typelib/librte_pmd_e1000/igb_rxtx.c+83 -150 replies
5/18ixgbe: support of unified packet typelib/librte_pmd_ixgbe/ixgbe_rxtx.c+112 -340 replies
6/18i40e: support of unified packet typelib/librte_pmd_i40e/i40e_rxtx.c+512 -2740 replies
7/18enic: support of unified packet typelib/librte_pmd_enic/enic_main.c+8 -60 replies
8/18vmxnet3: support of unified packet typelib/librte_pmd_vmxnet3/vmxnet3_rxtx.c+2 -20 replies
9/18fm10k: support of unified packet typelib/librte_pmd_fm10k/fm10k_rxtx.c+21 -90 replies
10/18app/test-pipeline: support of unified packet typeapp/test-pipeline/pipeline_hash.c+4 -30 replies
11/18app/testpmd: support of unified packet typeapp/test-pmd/csumonly.c app/test-pmd/rxonly.c+177 -110 replies
12/18app/test: Remove useless codeapp/test/packet_burst_generator.c+0 -101 reply
13/18examples/ip_fragmentation: support of unified packet typeexamples/ip_fragmentation/main.c+3 -40 replies
14/18examples/ip_reassembly: support of unified packet typeexamples/ip_reassembly/main.c+3 -40 replies
15/18examples/l3fwd-acl: support of unified packet typeexamples/l3fwd-acl/main.c+6 -130 replies
16/18examples/l3fwd-power: support of unified packet typeexamples/l3fwd-power/main.c+2 -30 replies
17/18examples/l3fwd: support of unified packet typeexamples/l3fwd/main.c+40 -310 replies
18/18mbuf: remove old packet type bit maskslib/librte_mbuf/rte_mbuf.c lib/librte_mbuf/rte_mbuf.h+4 -160 replies

Reviews trailers per patch

2 of 18 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchYong WangMaciej GajdzicaKonstantin AnanyevYong LiuHelin ZhangOlivier MatzAdrien Mazarguil
SeriesA-b T-b A-b A-b A-b
1/18
2/18
3/18
4/18
5/18
6/18
7/18
8/18A-b
9/18
10/18
11/18
12/18A-b
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/18] unified packet type

Currently only 6 bits which are stored in ol_flags are used to indicate the packet types. This is not enough, as some NIC hardware can recognize quite a lot of packet types, e.g i40e hardware can recognize more than 150 packet types. Hiding those packet types hides hardware offload capabilities which could be quite useful for improving performance and for end users. So an unified packet types are needed to support all possible PMDs. A 16 bits packet_type in mbuf structure can be changed to 32 bits and used for this purpose. In addition, all packet types stored in ol_flag field should be deleted at all, and 6 bits of ol_flags can be save as the benifit.

Initially, 32 bits of packet_type can be divided into several sub fields to indicate different packet type information of a packet. The initial design is to divide those bits into fields for L2 types, L3 types, L4 types, tunnel types, inner L2 types, inner L3 types and inner L4 types. All PMDs should translate the offloaded packet types into these 7 fields of information, for user applications.

v2 changes:
* Enlarged the packet_type field from 16 bits to 32 bits.
* Redefined the packet type sub-fields.
* Updated the 'struct rte_kni_mbuf' for KNI according to the mbuf changes.
* Used redefined packet types and enlarged packet_type field for all PMDs and corresponding applications.
* Removed changes in bond and its relevant application, as there is no need at all according to the recent bond changes.

v3 changes:
* Put the mbuf layout changes into a single patch.
* Put vector ixgbe changes right after mbuf changes.
* Disabled vector ixgbe PMD by default, as mbuf layout changed, and then re-enabled it after vector ixgbe PMD updated.
* Put the definitions of unified packet type into a single patch.
* Minor bug fixes and enhancements in l3fwd example.

v4 changes:
* Added detailed description of each packet types.
* Supported unified packet type of fm10k.
* Added printing logs of packet types of each received packet for rxonly mode in testpmd.
* Removed several useless code lines which block packet type unification from app/test/packet_burst_generator.c.

Helin Zhang (18):
mbuf: redefinition of packet_type in rte_mbuf
ixgbe: support of unified packet type for vector
mbuf: add definitions of unified packet types
e1000: support of unified packet type
ixgbe: support of unified packet type
i40e: support of unified packet type
enic: support of unified packet type
vmxnet3: support of unified packet type
fm10k: support of unified packet type app/test-pipeline: support of unified packet type app/testpmd: support of unified packet type app/test: Remove useless code examples/ip_fragmentation: support of unified packet type examples/ip_reassembly: support of unified packet type examples/l3fwd-acl: support of unified packet type examples/l3fwd-power: support of unified packet type examples/l3fwd: support of unified packet type
mbuf: remove old packet type bit masks

 app/test-pipeline/pipeline_hash.c                  |   7 +-
 app/test-pmd/csumonly.c                            |  10 +-
 app/test-pmd/rxonly.c                              | 178 ++++-
 app/test/packet_burst_generator.c                  |  10 -
 examples/ip_fragmentation/main.c                   |   7 +-
 examples/ip_reassembly/main.c                      |   7 +-
 examples/l3fwd-acl/main.c                          |  19 +-
 examples/l3fwd-power/main.c                        |   5 +-
 examples/l3fwd/main.c                              |  71 +-
 .../linuxapp/eal/include/exec-env/rte_kni_common.h |   4 +-
 lib/librte_mbuf/rte_mbuf.c                         |   6 -
 lib/librte_mbuf/rte_mbuf.h                         | 290 +++++++-
 lib/librte_pmd_e1000/igb_rxtx.c                    |  98 ++-
 lib/librte_pmd_enic/enic_main.c                    |  14 +-
 lib/librte_pmd_fm10k/fm10k_rxtx.c                  |  30 +-
 lib/librte_pmd_i40e/i40e_rxtx.c                    | 786 ++++++++++++++-------
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c                  | 146 +++-
 lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c              |  49 +-
 lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c              |   4 +-
 19 files changed, 1274 insertions(+), 467 deletions(-)
Signature · 1 line
1.9.3