qtest/ahci: add dma test
Status from this message: Thanks, applied to my block tree:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest19 patches 3 repliesApplied
- v219 patches 10 repliesSuperseded
- v119 patches 15 repliesSuperseded
Changes in v3 from the cover letter
(04) Changed "px" to "port" and "cx" to "slot" In this and all other patches. Kept R-Bys in other patches as this is a non-functional change.
(10) Modified aux to be an array of four bytes, and added a note explaining that they are for NCQ and not currently used in libqos.
(12) Minor formatting and updating aux initialization. Kept R-B.
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | libqos/ahci: Add ahci_port_select helpertests/ tests/ tests/ | +30 | 0 replies | |
| 2/19 | libqos/ahci: Add ahci_port_clear helpertests/ tests/ tests/ | +19 | 0 replies | |
| 3/19 | qtest/ahci: rename 'Command' to 'CommandHeader'tests/ tests/ | +7 | 0 replies | |
| 4/19 | libqos/ahci: Add command header helperstests/ tests/ tests/ | +110 | 1 reply | |
| 5/19 | libqos/ahci: Add ahci_port_check_error helpertests/ tests/ tests/ | +24 | 0 replies | |
| 6/19 | libqos/ahci: Add ahci_port_check_interrupts helpertests/ tests/ tests/ | +18 | 0 replies | |
| 7/19 | libqos/ahci: Add port_check_nonbusy helpertests/ tests/ tests/ | +20 | 0 replies | |
| 8/19 | libqos/ahci: Add cmd response sanity check helperstests/ tests/ tests/ | +88 | 0 replies | |
| 9/19 | qtest/ahci: Demagic ahci tests.tests/ tests/ | +59 | 0 replies | |
| 10/19 | qtest/ahci: add ahci_write_fistests/ tests/ tests/ | +17 | 1 reply | |
| 11/19 | libqos/ahci: Add ide cmd propertiestests/ | +39 | 0 replies | |
| 12/19 | libqos/ahci: add ahci command functionstests/ tests/ tests/ | +237 | 0 replies | |
| 13/19 | libqos/ahci: add ahci command verifytests/ tests/ tests/ | +18 | 0 replies | |
| 14/19 | libqos/ahci: add ahci command size setterstests/ tests/ | +26 | 0 replies | |
| 15/19 | libqos/ahci: Add ahci_guest_iotests/ tests/ | +17 | 0 replies | |
| 16/19 | libqos/ahci: add ahci_iotests/ tests/ tests/ | +52 | 0 replies | |
| 17/19 | libqos/ahci: Add ahci_clean_memtests/ tests/ tests/ +2 more | +28 | 0 replies | |
| 18/19 | qtest/ahci: Assert sector size in identify testtests/ | +4 | 0 replies | |
| 19/19 | qtest/ahci: Adding simple dma read-write testtests/ | +55 | 0 replies |
Reviews trailers per patch
All 19 patches have a Reviewed-by or Acked-by.
| Patch | Stefan Hajnoczi | Paolo Bonzini |
|---|---|---|
| 1/19 | R-b | |
| 2/19 | R-b | |
| 3/19 | R-b | |
| 4/19 | R-b | |
| 5/19 | R-b | |
| 6/19 | R-b | |
| 7/19 | R-b | |
| 8/19 | R-b | |
| 9/19 | R-b | |
| 10/19 | R-b | |
| 11/19 | R-b | |
| 12/19 | R-b | |
| 13/19 | R-b | |
| 14/19 | R-b | |
| 15/19 | R-b | |
| 16/19 | R-b | |
| 17/19 | R-b | |
| 18/19 | R-b | |
| 19/19 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 00/19] qtest/ahci: add dma test
Add a simple DMA r/w test to ahci-test.
Oh, and for the first 18 patches, refactor everything into helpers so that each ahci_test isn't a thousand lines long.
This patch depends upon the "ahci test preliminary refactoring" series upstream, which shuffled a lot of libqos and malloc facilities to support this series.
This patchset is a necessary step in checking in AHCI/DMA migration tests that I will later use as proof as suitability of enabling the ICH9 and AHCI migration flags.
V3:
(04) Changed "px" to "port" and "cx" to "slot" In this and all other patches. Kept R-Bys in other patches as this is a non-functional change.
(10) Modified aux to be an array of four bytes, and added a note explaining that they are for NCQ and not currently used in libqos.
(12) Minor formatting and updating aux initialization. Kept R-B.
V2:
(03) Added cpu_to_le16 into intermediary code.
(04) Fixed assignment to be or-equals. ahci_set_command_header no longer modifies its argument.
(09) Fixed assignment to be or-equals in the helper refactor.
(10) New patch. Writes an FIS to guest memory, handling endianness.
(11) Remove the property table sentinel
update find_command to use the array size instead.
(12) Remove cpu_to_le16 from ahci_command_commit,
leave endianness to ahci_write_fis.
(14) Remove cpu_to_le16 from ahci_set_sizes,
leave endianness to ahci_write_fis.
(19) qmemset the buffer to zeroes between IO calls,
just to make sure.
(--) Removed the ahci_macro_boot function patch
(...for now...)
(--) Retested entire stack of patches on F20/PPC.
~John
John Snow (19):
libqos/ahci: Add ahci_port_select helper libqos/ahci: Add ahci_port_clear helper qtest/ahci: rename 'Command' to 'CommandHeader' libqos/ahci: Add command header helpers libqos/ahci: Add ahci_port_check_error helper libqos/ahci: Add ahci_port_check_interrupts helper libqos/ahci: Add port_check_nonbusy helper libqos/ahci: Add cmd response sanity check helpers qtest/ahci: Demagic ahci tests. qtest/ahci: add ahci_write_fis libqos/ahci: Add ide cmd properties libqos/ahci: add ahci command functions libqos/ahci: add ahci command verify libqos/ahci: add ahci command size setters libqos/ahci: Add ahci_guest_io libqos/ahci: add ahci_io
libqos/ahci: Add ahci_clean_mem qtest/ahci: Assert sector size in identify test qtest/ahci: Adding simple dma read-write test
tests/ahci-test.c | 230 ++++++++------------ tests/libqos/ahci.c | 569 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/libqos/ahci.h | 168 ++++++++++++--- tests/libqos/malloc.c | 5 + tests/libqos/malloc.h | 1 + 5 files changed, 804 insertions(+), 169 deletions(-)
Signature · 1 line
1.9.3