Skip to content

add support for pmic_arb v2 and correct framework

Gilad Avidov linux-arm-msm lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 3 repliesIn review
  2. v42 patches 7 repliesSuperseded
  3. v32 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v22 patches7 repliesSuperseded

Changes in v5 from the cover letter

* remove the unmap added in v4 since it is used again and the mapping is managed.
* correct printf formatting for 64bit compilers.
* correct base address for reading the channel table.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2spmi: remove wakeup command before slave probedrivers/spmi/spmi.c+2 -70 replies
2/2spmi: pmic_arb: add support for hw version 2Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt drivers/spmi/spmi-pmic-arb.c+265 -600 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchStephen BoydSagar DhariaJosh CartwrightIvan T. Ivanov
SeriesT-b
1/2R-b R-b A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH V5 0/2] add support for pmic_arb v2 and correct framework

pmic_arb v2 has no support for spmi non-data commands and thus returns -EOPNOTSUPP on .cmd callback. This causes a failure in spmi_drv_probe() which sends a wakeup command to the slave before probing its driver. This patchset removes the wakeup from spmi_drv_probe() since the spmi spec stipulates that a slaves default state is active and doesn't need a wakeup.

Changes from v3 to v4:
* Remove the claim that this is a bug fix off the commit text
* Unmap the core register space as soon as we know that it will not be used
* Assign the core reg space to a local until we know if it appropriate to use it to configure the controller fields (on v1) or unmap it (on v2).

Changes from v4 to v5:
* remove the unmap added in v4 since it is used again and the mapping is managed.
* correct printf formatting for 64bit compilers.
* correct base address for reading the channel table.

Gilad Avidov (2):
spmi: remove wakeup command before slave probe
spmi: pmic_arb: add support for hw version 2

 .../bindings/spmi/qcom,spmi-pmic-arb.txt           |   6 +-
 drivers/spmi/spmi-pmic-arb.c                       | 319 +++++++++++++++++----
 drivers/spmi/spmi.c                                |   9 +-
 3 files changed, 267 insertions(+), 67 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation