Drivers: hv: Further protection for the rescind path
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | Drivers: hv: vmbus: implement get/put usage workflow for vmbus channelsdrivers/ drivers/ drivers/ +1 more | +60 | 5 replies | |
| 2/4 | Drivers: hv: vmbus: do not lose rescind offer on failure in vmbus_process_offer()drivers/ | +18 | 1 reply | |
| 3/4 | Drivers: hv: vmbus: protect vmbus_get_outgoing_channel() against channel removaldrivers/ drivers/ | +9 | 1 reply | |
| 4/4 | hyperv: netvsc: improve protection against rescind offerdrivers/ | +8 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] Drivers: hv: Further protection for the rescind path
This series is a continuation of the "Drivers: hv: vmbus: serialize Offer and Rescind offer". I'm trying to address a number of theoretically possible issues with rescind offer handling. All these complications come from the fact that a rescind offer results in vmbus channel being freed and we must ensure nobody still uses it. Instead of introducing new locks I suggest we switch channels usage to the get/put workflow.
The main part of the series is [PATCH 1/4] which introduces the workflow for vmbus channels, all other patches fix different corner cases using this workflow. I'm not sure all such cases are covered with this series (probably not), but in case protection is required in some other places it should become relatively easy to add one.
I did some sanity testing with CONFIG_DEBUG_LOCKDEP=y and nothing popped out, however, additional testing would be much appreciated.
K.Y., Haiyang, I'm not sending this series to netdev@ and linux-scsi@ as it is supposed to be applied as a whole, please resend these patches with your sign-offs when (and if) we're done with reviews. Thanks!
Vitaly Kuznetsov (4):
Drivers: hv: vmbus: implement get/put usage workflow for vmbus
channels
Drivers: hv: vmbus: do not lose rescind offer on failure in
vmbus_process_offer()
Drivers: hv: vmbus: protect vmbus_get_outgoing_channel() against
channel removal
hyperv: netvsc: improve protection against rescind offer
drivers/hv/channel_mgmt.c | 75 +++++++++++++++++++++++++++++++++++++-------- drivers/hv/connection.c | 7 +++-- drivers/hv/hyperv_vmbus.h | 4 +++ drivers/net/hyperv/netvsc.c | 10 ++++-- drivers/scsi/storvsc_drv.c | 2 ++ include/linux/hyperv.h | 13 ++++++++ 6 files changed, 95 insertions(+), 16 deletions(-)
Signature · 1 line
1.9.3