Skip to content

tipc: resolve message disordering problem

Jon Maloy netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9tipc: reduce usage of context info in socket and linknet/tipc/bcast.c net/tipc/bcast.h net/tipc/discover.c +7 more+98 -910 replies
2/9tipc: simplify message forwarding and rejection in socket layernet/tipc/socket.c+58 -620 replies
3/9tipc: enqueue arrived buffers in socket in separate functionnet/tipc/socket.c+31 -150 replies
4/9tipc: split up function tipc_msg_eval()net/tipc/msg.c net/tipc/msg.h net/tipc/socket.c+48 -430 replies
5/9tipc: use existing sk_write_queue for outgoing packet chainnet/tipc/socket.c+13 -180 replies
6/9tipc: resolve race problem at unicast message receptionnet/tipc/bcast.c net/tipc/link.c net/tipc/link.h +8 more+372 -2410 replies
7/9tipc: simplify connection abort notifications when links breaknet/tipc/node.c+29 -400 replies
8/9tipc: simplify socket multicast receptionnet/tipc/bcast.c net/tipc/bcast.h net/tipc/name_table.c +3 more+84 -1010 replies
9/9tipc: eliminate race condition at multicast receptionnet/tipc/bcast.c net/tipc/bcast.h net/tipc/msg.h +5 more+114 -590 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchYing Xue
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/9] tipc: resolve message disordering problem

When TIPC receives messages from multi-threaded device drivers it may occasionally deliver messages to their destination sockets in the wrong order. This happens despite correct resequencing at the link layer, because the upcall path from link to socket is not protected by any locks.

These commits solve this problem by introducing an 'input' message queue in each link, through which messages must be delivered to the upper layers.

Jon Maloy (9):
tipc: reduce usage of context info in socket and link
tipc: simplify message forwarding and rejection in socket layer
tipc: enqueue arrived buffers in socket in separate function
tipc: split up function tipc_msg_eval()
tipc: use existing sk_write_queue for outgoing packet chain
tipc: resolve race problem at unicast message reception
tipc: simplify connection abort notifications when links break
tipc: simplify socket multicast reception
tipc: eliminate race condition at multicast reception

 net/tipc/bcast.c      | 121 ++++++----------
 net/tipc/bcast.h      |  29 ++--
 net/tipc/discover.c   |   3 +-
 net/tipc/link.c       | 301 +++++++++++++++++----------------------
 net/tipc/link.h       |  14 +-
 net/tipc/msg.c        | 109 ++++++++------
 net/tipc/msg.h        | 107 ++++++++++++--
 net/tipc/name_distr.c |  38 +++--
 net/tipc/name_distr.h |   2 +-
 net/tipc/name_table.c |  44 +++++-
 net/tipc/name_table.h |  20 ++-
 net/tipc/node.c       | 103 +++++++-------
 net/tipc/node.h       |  22 ++-
 net/tipc/socket.c     | 382 +++++++++++++++++++++++++++++---------------------
 net/tipc/socket.h     |   8 +-
 15 files changed, 740 insertions(+), 563 deletions(-)
Signature · 1 line
1.9.1