Skip to content

Prefer wbinvd() where appropriate

Ben Widawsky intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915: Remove the useless flush_chipsetdrivers/gpu/drm/i915/intel_lrc.c+1 -21 reply
2/6drm/i915: Pass eb_vmas to execbuffer implementationsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c +1 more+28 -221 reply
3/6drm/i915: Opportunistically reduce flushing at execbufdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_execbuffer.c +1 more+37 -121 reply
4/6drm/i915: Add debugfs knobs for wbinvd thresholddrivers/gpu/drm/i915/i915_debugfs.c+34 -00 replies
5/6drm/i915: Extract checking the necessity of flushdrivers/gpu/drm/i915/i915_gem.c+30 -230 replies
6/6drm/i915: obey wbinvd threshold in more placesdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_gtt.c+42 -72 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchPRC QA PRTS (Patch Regression Test System Contact:
1/6
2/6
3/6
4/6
5/6
6/6T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] Prefer wbinvd() where appropriate

A while back we had a workload which severely suffered from excessive clflushing. I sent out a patch series which solved this generically in DRM core, but that had the unfortunate side effect of possibly regressing non-intel platforms.

I've re-spun the series to only take this shortcut when on an Intel platform. This series is untested by me since we've now worked around the problem in a different way within mesa. Jesse asked me to send this out, though I don't have time to see if it's still useful (until my mesa patches are merged, it would be useful, but afterwards, I do not know). I also didn't check that I rebased things properly.

Do what you want with them...

Ben Widawsky (6):
drm/i915: Remove the useless flush_chipset drm/i915: Pass eb_vmas to execbuffer implementations drm/i915: Opportunistically reduce flushing at execbuf drm/i915: Add debugfs knobs for wbinvd threshold drm/i915: Extract checking the necessity of flush drm/i915: obey wbinvd threshold in more places

 drivers/gpu/drm/i915/i915_debugfs.c        | 34 +++++++++++
 drivers/gpu/drm/i915/i915_drv.h            | 25 +++++++-
 drivers/gpu/drm/i915/i915_gem.c            | 96 ++++++++++++++++++++----------
 drivers/gpu/drm/i915/i915_gem_execbuffer.c | 46 +++++++-------
 drivers/gpu/drm/i915/i915_gem_gtt.c        | 13 +++-
 drivers/gpu/drm/i915/intel_lrc.c           | 21 ++++---
 drivers/gpu/drm/i915/intel_lrc.h           |  3 +-
 7 files changed, 172 insertions(+), 66 deletions(-)
Signature · 6 lines
2.3.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx