Skip to content

hmp: Normalize HMP command handler names

Markus Armbruster qemu-devel qemu-trivial 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hmp: Clean up declarations for long-gone info handlersinclude/migration/migration.h include/sysemu/sysemu.h include/ui/qemu-spice.h+0 -100 replies
2/3hmp: Name HMP command handler functions hmp_COMMAND()block/block-backend.c blockdev.c device-hotplug.c +18 more+110 -1100 replies
3/3hmp: Name HMP info handler functions hmp_info_SUBCOMMAND()hw/core/loader.c hw/intc/i8259.c hw/intc/lm32_pic.c +18 more+71 -710 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKevin WolfJason Wang
SeriesA-b A-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names

When I can't guess a handler's name, I have to look it up in hmp-commands.hx. Happens often enough to annoy me. Let's make them more predictable.

Touches several subsystems because HMP command handlers are still spread far and wide, but the changes are trivial. Speak up if you want your subsystem's part routed through your tree rather than -trivial.

Cc Kevin Wolf <[email protected]>
Cc Stefan Hajnoczi <[email protected]>
Cc Michael Walle <[email protected]>
Cc "Michael S. Tsirkin" <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Jason Wang <[email protected]>

Markus Armbruster (3):
hmp: Clean up declarations for long-gone info handlers
hmp: Name HMP command handler functions hmp_COMMAND()
hmp: Name HMP info handler functions hmp_info_SUBCOMMAND()

 block/block-backend.c          |   6 +-
 blockdev.c                     |   6 +-
 device-hotplug.c               |   2 +-
 hmp-commands.hx                |  86 +++++++++++++-------------
 hmp.c                          |   6 +-
 hmp.h                          |   6 +-
 hw/core/loader.c               |   2 +-
 hw/intc/i8259.c                |   4 +-
 hw/intc/lm32_pic.c             |   4 +-
 hw/pci/pci-hotplug-old.c       |   4 +-
 hw/pci/pci-stub.c              |   2 +-
 hw/pci/pcie_aer.c              |   2 +-
 hw/sparc/sun4m.c               |   4 +-
 hw/usb/bus.c                   |   2 +-
 hw/usb/host-libusb.c           |   2 +-
 hw/usb/host-stub.c             |   2 +-
 include/hw/i386/pc.h           |   4 +-
 include/hw/lm32/lm32_pic.h     |   4 +-
 include/hw/loader.h            |   2 +-
 include/hw/sparc/sun4m.h       |   4 +-
 include/hw/usb.h               |   2 +-
 include/migration/migration.h  |   4 --
 include/monitor/qdev.h         |   4 +-
 include/net/net.h              |   6 +-
 include/net/slirp.h            |   6 +-
 include/sysemu/block-backend.h |   2 +-
 include/sysemu/blockdev.h      |   4 +-
 include/sysemu/sysemu.h        |  23 +++----
 include/ui/console.h           |   2 +-
 include/ui/qemu-spice.h        |   3 -
 monitor.c                      | 134 ++++++++++++++++++++---------------------
 net/net.c                      |   6 +-
 net/slirp.c                    |   6 +-
 qdev-monitor.c                 |   4 +-
 savevm.c                       |   6 +-
 ui/input.c                     |   2 +-
 vl.c                           |   4 +-
 37 files changed, 181 insertions(+), 191 deletions(-)
Signature · 1 line
1.9.3