Skip to content

Remove the outstanding_lazy_request

[email protected] intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest51 patches 45 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/51drm/i915: Rename 'flags' to 'dispatch_flags' for better code readingdrivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_lrc.h +2 more+41 -353 replies
2/51drm/i915: Add missing trace point to LRC execbuff code pathdrivers/gpu/drm/i915/intel_lrc.c+2 -00 replies
3/51drm/i915: Cache ringbuf pointer in request structuredrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/intel_lrc.c +1 more+8 -161 reply
4/51drm/i915: Merged the many do_execbuf() parameters into a structuredrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c +1 more+67 -515 replies
5/51drm/i915: Add return code check to i915_gem_execbuffer_retire_commands()drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c+9 -1510 replies
6/51drm/i915: Wrap request allocation with a function pointerdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/intel_lrc.c +3 more+14 -60 replies
7/51drm/i915: Early alloc request in execbuffdrivers/gpu/drm/i915/i915_gem_execbuffer.c+10 -33 replies
8/51drm/i915: Update alloc_request to return the allocated requestdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c +3 more+27 -124 replies
9/51drm/i915: Add request to execbuf params and add explicit cleanupdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem_execbuffer.c+12 -20 replies
10/51drm/i915: Update the dispatch tracepoint to use params->requestdrivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c+2 -20 replies
11/51drm/i915: Update move_to_gpu() to take a request structuredrivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c+9 -110 replies
12/51drm/i915: Update execbuffer_move_to_active() to take a request structuredrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c+5 -50 replies
13/51drm/i915: Add flag to i915_add_request() to skip the cache flushdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_execbuffer.c +2 more+19 -190 replies
14/51drm/i915: Update pin_to_display_plane() to do explicit request managementdrivers/gpu/drm/i915/i915_gem.c+18 -31 reply
15/51drm/i915: Update i915_gem_object_sync() to take a request structuredrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_execbuffer.c +1 more+7 -60 replies
16/51drm/i915: Update i915_gpu_idle() to manage its own requestdrivers/gpu/drm/i915/i915_gem.c+17 -10 replies
17/51drm/i915: Split i915_ppgtt_init_hw() in half - generic and per ringdrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/i915_gem_gtt.h+36 -180 replies
18/51drm/i915: Moved the for_each_ring loop outside of i915_gem_context_enable()drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_context.c+23 -290 replies
19/51drm/i915: Add explicit request management to i915_gem_init_hw()drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_gtt.c +2 more+26 -130 replies
20/51drm/i915: Update ppgtt_init_ring() & context_enable() to take requestsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_context.c +2 more+11 -100 replies
21/51drm/i915: Set context in request from creation even in legacy modedrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/intel_ringbuffer.c+3 -80 replies
22/51drm/i915: Update i915_switch_context() to take a request structuredrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_context.c +1 more+12 -160 replies
23/51drm/i915: Update do_switch() to take a request structuredrivers/gpu/drm/i915/i915_gem_context.c+9 -80 replies
24/51drm/i915: Update deferred context creation to do explicit request managementdrivers/gpu/drm/i915/intel_lrc.c+16 -15 replies
25/51drm/i915: Update init_context() to take a request structuredrivers/gpu/drm/i915/i915_gem_context.c drivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_ringbuffer.c +1 more+10 -130 replies
26/51drm/i915: Update render_state_init() to take a request structuredrivers/gpu/drm/i915/i915_gem_render_state.c drivers/gpu/drm/i915/i915_gem_render_state.h drivers/gpu/drm/i915/intel_lrc.c +2 more+22 -250 replies
27/51drm/i915: Update overlay code to do explicit request managementdrivers/gpu/drm/i915/intel_overlay.c+48 -160 replies
28/51drm/i915: Update queue_flip() to do explicit request managementdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_ringbuffer.c +1 more+32 -200 replies
29/51drm/i915: Update add_request() to take a request structuredrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_execbuffer.c +4 more+24 -230 replies
30/51drm/i915: Update [vma|object]_move_to_active() to take request structuresdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_context.c +3 more+13 -140 replies
31/51drm/i915: Update l3_remap to take a request structuredrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_context.c+5 -40 replies
32/51drm/i915: Update mi_set_context() to take a request structuredrivers/gpu/drm/i915/i915_gem_context.c+4 -50 replies
33/51drm/i915: Update a bunch of execbuffer heplers to take request structuresdrivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_ringbuffer.c +1 more+14 -120 replies
34/51drm/i915: Update workarounds_emit() to take request structuresdrivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_ringbuffer.c+10 -100 replies
35/51drm/i915: Update flush_all_caches() to take request structuresdrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_lrc.h +2 more+13 -140 replies
36/51drm/i915: Update switch_mm() to take a request structuredrivers/gpu/drm/i915/i915_gem_context.c drivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/i915_gem_gtt.h+14 -100 replies
37/51drm/i915: Update ring->flush() to take a requests structuredrivers/gpu/drm/i915/i915_gem_context.c drivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/intel_ringbuffer.c +1 more+24 -160 replies
38/51drm/i915: Update some flush helpers to take request structuresdrivers/gpu/drm/i915/intel_ringbuffer.c+16 -130 replies
39/51drm/i915: Update ring->emit_flush() to take a request structuredrivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_ringbuffer.h+9 -110 replies
40/51drm/i915: Update ring->add_request() to take a request structuredrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/intel_ringbuffer.c drivers/gpu/drm/i915/intel_ringbuffer.h+14 -160 replies
41/51drm/i915: Update ring->emit_request() to take a request structuredrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_ringbuffer.h+5 -70 replies
42/51drm/i915: Update ring->dispatch_execbuffer() to take a request structuredrivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/i915_gem_render_state.c drivers/gpu/drm/i915/intel_ringbuffer.c +1 more+16 -110 replies
43/51drm/i915: Update ring->emit_bb_start() to take a request structuredrivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_ringbuffer.h+6 -90 replies
44/51drm/i915: Update ring->sync_to() to take a request structuredrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/intel_ringbuffer.c drivers/gpu/drm/i915/intel_ringbuffer.h+7 -50 replies
45/51drm/i915: Update ring->signal() to take a request structuredrivers/gpu/drm/i915/intel_ringbuffer.c drivers/gpu/drm/i915/intel_ringbuffer.h+11 -110 replies
46/51drm/i915: Update cacheline_align() to take a request structuredrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_ringbuffer.c drivers/gpu/drm/i915/intel_ringbuffer.h+4 -30 replies
47/51drm/i915: Update ironlake_enable_rc6() to do explicit request managementdrivers/gpu/drm/i915/intel_pm.c+21 -109 replies
48/51drm/i915: Update intel_ring_begin() to take a request structuredrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_context.c drivers/gpu/drm/i915/i915_gem_execbuffer.c +6 more+55 -592 replies
49/51drm/i915: Update intel_logical_ring_begin() to take a request structuredrivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_lrc.h+17 -212 replies
50/51drm/i915: Remove the now obsolete intel_ring_get_request()drivers/gpu/drm/i915/intel_ringbuffer.h+0 -70 replies
51/51drm/i915: Remove the now obsolete 'outstanding_lazy_request'drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/intel_lrc.c +2 more+6 -410 replies

Reviews trailers per patch

None of the 51 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTomas Elf
SeriesR-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b
1/51
2/51
3/51
4/51
5/51
6/51
7/51
8/51
9/51
10/51
11/51
12/51
13/51
14/51
15/51
16/51
17/51
18/51
19/51
20/51
21/51
22/51
23/51
24/51
25/51
26/51
27/51
28/51
29/51
30/51
31/51
32/51
33/51
34/51
35/51
36/51
37/51
38/51
39/51
40/51
41/51
42/51
43/51
44/51
45/51
46/51
47/51
48/51
49/51
50/51
51/51

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/51] Remove the outstanding_lazy_request

From: John Harrison <[email protected]>

The driver tracks GPU work using request structures. Unfortunately, this tracking is not currently explicit but is done by means of a catch-all request that floats around in the background hoovering up work until it gets submitted. This background request (ring->outstanding_lazy_request or OLR) is created at the point of actually writing to the ring rather than when a particular piece of GPU work is started. This scheme sort of hangs together but causes a number of issues. It can mean that multiple pieces of independent work are lumped together in the same request or that work is not officially submitted until much later than it was created.

This patch series completely removes the OLR and explicitly tracks each piece of work with it's own personal request structure from start to submission.

The patch set seems to fix the "'gem_ringfill --r render' + ctrl-c straight after boot" issue logged as BZ:40112. I haven't done any analysis of that particular issue but the descriptions I've seen appear to blame an inconsistent or mangled OLR.

Note also that by the end of this series, a number of differences between the legacy and execlist code paths have been removed. For example add_request() and emit_request() now have the same signature thus could be merged back to a single function pointer. Merging some of these together would also allow the removal of a bunch of 'if(execlists)' tests where the difference is simply to call the legacy function or the execlist one.

[Patches against drm-intel-nightly tree fetched 03/02/2015]

John Harrison (51):
drm/i915: Rename 'flags' to 'dispatch_flags' for better code reading drm/i915: Add missing trace point to LRC execbuff code path drm/i915: Cache ringbuf pointer in request structure
drm/i915: Merged the many do_execbuf() parameters into a structure drm/i915: Add return code check to i915_gem_execbuffer_retire_commands() drm/i915: Wrap request allocation with a function pointer drm/i915: Early alloc request in execbuff
drm/i915: Update alloc_request to return the allocated request drm/i915: Add request to execbuf params and add explicit cleanup drm/i915: Update the dispatch tracepoint to use params->request drm/i915: Update move_to_gpu() to take a request structure drm/i915: Update execbuffer_move_to_active() to take a request structure drm/i915: Add flag to i915_add_request() to skip the cache flush drm/i915: Update pin_to_display_plane() to do explicit request management drm/i915: Update i915_gem_object_sync() to take a request structure drm/i915: Update i915_gpu_idle() to manage its own request drm/i915: Split i915_ppgtt_init_hw() in half - generic and per ring drm/i915: Moved the for_each_ring loop outside of i915_gem_context_enable() drm/i915: Add explicit request management to i915_gem_init_hw() drm/i915: Update ppgtt_init_ring() & context_enable() to take requests drm/i915: Set context in request from creation even in legacy mode drm/i915: Update i915_switch_context() to take a request structure drm/i915: Update do_switch() to take a request structure drm/i915: Update deferred context creation to do explicit request management drm/i915: Update init_context() to take a request structure drm/i915: Update render_state_init() to take a request structure drm/i915: Update overlay code to do explicit request management drm/i915: Update queue_flip() to do explicit request management drm/i915: Update add_request() to take a request structure drm/i915: Update [vma|object]_move_to_active() to take request structures drm/i915: Update l3_remap to take a request structure
drm/i915: Update mi_set_context() to take a request structure drm/i915: Update a bunch of execbuffer heplers to take request structures drm/i915: Update workarounds_emit() to take request structures drm/i915: Update flush_all_caches() to take request structures drm/i915: Update switch_mm() to take a request structure drm/i915: Update ring->flush() to take a requests structure drm/i915: Update some flush helpers to take request structures drm/i915: Update ring->emit_flush() to take a request structure drm/i915: Update ring->add_request() to take a request structure drm/i915: Update ring->emit_request() to take a request structure drm/i915: Update ring->dispatch_execbuffer() to take a request structure drm/i915: Update ring->emit_bb_start() to take a request structure drm/i915: Update ring->sync_to() to take a request structure drm/i915: Update ring->signal() to take a request structure drm/i915: Update cacheline_align() to take a request structure drm/i915: Update ironlake_enable_rc6() to do explicit request management drm/i915: Update intel_ring_begin() to take a request structure drm/i915: Update intel_logical_ring_begin() to take a request structure drm/i915: Remove the now obsolete intel_ring_get_request() drm/i915: Remove the now obsolete 'outstanding_lazy_request'

 drivers/gpu/drm/i915/i915_drv.h              |   68 +++---
 drivers/gpu/drm/i915/i915_gem.c              |  207 +++++++++++--------
 drivers/gpu/drm/i915/i915_gem_context.c      |   76 +++----
 drivers/gpu/drm/i915/i915_gem_execbuffer.c   |  138 ++++++++-----
 drivers/gpu/drm/i915/i915_gem_gtt.c          |   55 ++---
 drivers/gpu/drm/i915/i915_gem_gtt.h          |    3 +-
 drivers/gpu/drm/i915/i915_gem_render_state.c |   16 +-
 drivers/gpu/drm/i915/i915_gem_render_state.h |    2 +-
 drivers/gpu/drm/i915/intel_display.c         |   61 +++---
 drivers/gpu/drm/i915/intel_lrc.c             |  186 +++++++++--------
 drivers/gpu/drm/i915/intel_lrc.h             |   20 +-
 drivers/gpu/drm/i915/intel_overlay.c         |   64 ++++--
 drivers/gpu/drm/i915/intel_pm.c              |   33 ++-
 drivers/gpu/drm/i915/intel_ringbuffer.c      |  287 ++++++++++++++------------
 drivers/gpu/drm/i915/intel_ringbuffer.h      |   51 ++---
 15 files changed, 697 insertions(+), 570 deletions(-)
Signature · 6 lines
1.7.9.5

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx