Skip to content

FocalTech touchpad fixes

Mathias Gottschlag linux-input lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v13 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4psmouse: Remove hardcoded touchpad size from the focaltech driver.drivers/input/mouse/focaltech.c+1 -40 replies
2/4psmouse: Ensure that the focaltech driver reports consistent coordinates.drivers/input/mouse/focaltech.c+10 -20 replies
3/4psmouse: Disable resolution/rate/scale changes for FocalTech touchpads.drivers/input/mouse/focaltech.c drivers/input/mouse/psmouse-base.c drivers/input/mouse/psmouse.h+48 -11 reply
4/4psmouse: Disable "palm detection" in the focaltech driver.drivers/input/mouse/focaltech.c+0 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/4] FocalTech touchpad fixes

Hi,

Changes since the last version:
- I added a commit which clamps the reported coordinates to valid values, even if the values reported by the touchpad are wrong/misinterpreted.
- PSMOUSE_CMD_SETSCALE11 is now encapsulated in a member function of struct psmouse, like the other configuration commands, and focaltech.c provides a dummy function.
- I added a commit which disables palm detection. The driver used to check the reported contact size from the touchpad. However, the threshold of the value for "very large contact area" seems to be rather low on some devices, leading to frequent pointer freezes. As I don't know how to indentify these devices, I thought it would be better to disable the check for now. If you don't agree with this patch, we can surely leave it out, but I don't know how to fix the problem and would rather not have devices where the driver is known to be broken.

Especially, the last commit now removes some code which so far is the only available documentation for the touchpad behaviour.
As soon as I find some time (haha), I'll probably write some documentation. Would such documentation (as incomplete and probably wrong as it will be) be suitable for Documentation/, or should I make it available through a different channel?

Regards,
Mathias

Mathias Gottschlag (4):
psmouse: Remove hardcoded touchpad size from the focaltech driver.
psmouse: Ensure that the focaltech driver reports consistent
coordinates.
psmouse: Disable resolution/rate/scale changes for FocalTech
touchpads.
psmouse: Disable "palm detection" in the focaltech driver.

 drivers/input/mouse/focaltech.c    | 49 ++++++++++++++++++++++++++------------
 drivers/input/mouse/psmouse-base.c | 18 +++++++++++++-
 drivers/input/mouse/psmouse.h      |  7 ++++++
 3 files changed, 58 insertions(+), 16 deletions(-)
Signature · 1 line
2.1.0