Skip to content

Fix up aio splats at reboot garbage collection

Paul Gortmaker linux-rt-users 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2aio: don't take the ctx_lock during rcu garbage collection at rebootfs/aio.c+7 -01 reply
2/2aio: fix splat in free_ioctx_reqs by using percpu callbackfs/aio.c+6 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH-rt 0/2] Fix up aio splats at reboot garbage collection

We ran into a splat during reboot that was caused by the percpu_ref_kill garbage collection in the fs/aio code.

After researching a bit, it was determined that this was the same problem reported by Mike a few months ago[1]. In that thread, several possibilities were discussed, but no patches were added to -rt in the end out of that discussion.

This implements one of the possible solutions discussed there, which is -rt specific and not mainline appropriate.

After using that patch, we found another new follow on splat that was also in aio garbage collection and so we deal with that by using the callback ("confirm") version of percpu_ref_kill to delay the schedule_work to a non-atomic context to avoid the second splat. I think this second patch could be used in mainline, if one desired to do so.

[1] https://lkml.org/lkml/2014/6/8/10

Paul.
---

Paul Gortmaker (2):
aio: don't take the ctx_lock during rcu garbage collection at reboot
aio: fix splat in free_ioctx_reqs by using percpu callback

 fs/aio.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)
Signature · 1 line
2.1.0