Skip to content

QemuOpts: Convert various setters to Error

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13QemuOpts: Convert qemu_opt_set_bool() to Error, fix its useblockdev.c include/qemu/option.h tests/test-qemu-opts.c +3 more+19 -181 reply
2/13QemuOpts: Convert qemu_opt_set_number() to Error, fix its useblock.c block/nbd.c block/qcow2.c +6 more+25 -221 reply
3/13QemuOpts: Convert qemu_opts_set() to Error, fix its useinclude/qemu/option.h net/net.c tests/test-qemu-opts.c +2 more+22 -181 reply
4/13qemu-img: Suppress unhelpful extra errors in convert, resizeqemu-img.c+12 -43 replies
5/13block: Suppress unhelpful extra errors in bdrv_img_create()block.c+5 -21 reply
6/13QemuOpts: Drop qemu_opt_set(), rename qemu_opt_set_err(), fix useblock.c block/qcow2.c block/vvfat.c +15 more+131 -1312 replies
7/13QemuOpts: Propagate errors through opts_do_parse()util/qemu-option.c+17 -81 reply
8/13QemuOpts: Propagate errors through opts_parse()util/qemu-option.c+20 -91 reply
9/13qemu-img: Suppress unhelpful extra errors in convert, amendblock.c include/qemu/option.h qemu-char.c +2 more+40 -222 replies
10/13block: Simplify setting numeric optionsblockdev.c vl.c+7 -101 reply
11/13qemu-sockets: Simplify setting numeric and boolean optionsutil/qemu-sockets.c+7 -91 reply
12/13pc: Use qemu_opt_set() instead of qemu_opts_parse()hw/i386/pc.c+3 -81 reply
13/13qtest: Use qemu_opt_set() instead of qemu_opts_parse()qtest.c+4 -71 reply

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/13] QemuOpts: Convert various setters to Error

Bonus: improve qemu-img error reporting slightly.

Perhaps the block maintainers want to pick this up. If not, I'm happy to route it through my tree.

Markus Armbruster (13):
QemuOpts: Convert qemu_opt_set_bool() to Error, fix its use
QemuOpts: Convert qemu_opt_set_number() to Error, fix its use
QemuOpts: Convert qemu_opts_set() to Error, fix its use
qemu-img: Suppress unhelpful extra errors in convert, resize
block: Suppress unhelpful extra errors in bdrv_img_create()
QemuOpts: Drop qemu_opt_set(), rename qemu_opt_set_err(), fix use
QemuOpts: Propagate errors through opts_do_parse()
QemuOpts: Propagate errors through opts_parse()
qemu-img: Suppress unhelpful extra errors in convert, amend
block: Simplify setting numeric options
qemu-sockets: Simplify setting numeric and boolean options
pc: Use qemu_opt_set() instead of qemu_opts_parse()
qtest: Use qemu_opt_set() instead of qemu_opts_parse()

 block.c                  |  17 +++++---
 block/nbd.c              |   3 +-
 block/qcow2.c            |   5 ++-
 block/vvfat.c            |   5 ++-
 blockdev.c               |  25 ++++++------
 hw/i386/pc.c             |  11 ++---
 hw/pci/pci-hotplug-old.c |   2 +-
 hw/usb/dev-network.c     |   4 +-
 hw/usb/dev-storage.c     |   6 +--
 hw/watchdog/watchdog.c   |   2 +-
 include/qemu/option.h    |  18 +++++----
 net/net.c                |   6 +--
 qdev-monitor.c           |   6 +--
 qemu-char.c              |  68 +++++++++++++++++--------------
 qemu-img.c               |  44 ++++++++++++++------
 qtest.c                  |  11 ++---
 tests/test-qemu-opts.c   |  38 +++++++++---------
 util/qemu-config.c       |   9 ++++-
 util/qemu-option.c       | 100 +++++++++++++++++++++++-----------------------
 util/qemu-sockets.c      |  42 +++++++++----------
 vl.c                     | 102 ++++++++++++++++++++++++++---------------------
 21 files changed, 284 insertions(+), 240 deletions(-)
Signature · 1 line
1.9.3