Skip to content

net: dsa: integration with SWITCHDEV for HW bridging

Florian Fainelli netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v23 patches 6 repliesSuperseded
  3. v1 RFC2 patches 62 repliesSuperseded

Changes in v3 from the cover letter

- add back the null pointer check in dsa_slave_br_port_mask from Guenter
- slightly rework patch 1 commit message not to mention the function name we add in patch 2

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: dsa: Ensure that port array elements are initialized before being usednet/dsa/dsa.c net/dsa/dsa_priv.h net/dsa/slave.c+13 -170 replies
2/3net: dsa: integrate with SWITCHDEV for HW bridginginclude/net/dsa.h net/dsa/Kconfig net/dsa/dsa.c +2 more+171 -01 reply
3/3net: dsa: bcm_sf2: add HW bridging supportdrivers/net/dsa/bcm_sf2.c drivers/net/dsa/bcm_sf2.h drivers/net/dsa/bcm_sf2_regs.h+171 -10 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchGuenter Roeck
1/3
2/3R-b T-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/3] net: dsa: integration with SWITCHDEV for HW bridging

Hi all,

This patch set provides the DSA and SWITCHDEV integration bits together and modifies the bcm_sf2 driver accordingly such that it works properly with HW bridging.

Changes in v3:

- add back the null pointer check in dsa_slave_br_port_mask from Guenter
- slightly rework patch 1 commit message not to mention the function name we add in patch 2

Changes in v2:

- avoid a race condition in how DSA network devices are created, patch from Guenter Roeck
- provide a consistent and work STP state once a port leaves the bridge
- retain a bridge device pointer to properly flag port/bridge membership
- properly flush the ARL (Address Resolution Logic) in bcm_sf2.c
- properly retain port membership when individually bringing devices up/down while they are members of a bridge

We discussed on the mailing-list the possibility of standardizing a "fdb_flush" operation for DSA switch drivers, looking at the Marvell and Broadcom switches, I am not convinced this is practical or diserable as the terminologies vary here, but there is nothing preventing us from doing it later.

Many thanks to Guenter and Andrew for both testing and providing feedback.

Thanks!

Florian Fainelli (2):
net: dsa: integrate with SWITCHDEV for HW bridging
net: dsa: bcm_sf2: add HW bridging support

Guenter Roeck (1):
net: dsa: Ensure that port array elements are initialized before being
used

 drivers/net/dsa/bcm_sf2.c      | 155 ++++++++++++++++++++++++++++++++++++++-
 drivers/net/dsa/bcm_sf2.h      |   2 +
 drivers/net/dsa/bcm_sf2_regs.h |  15 ++++
 include/net/dsa.h              |  10 +++
 net/dsa/Kconfig                |   1 +
 net/dsa/dsa.c                  |  17 +++--
 net/dsa/dsa_priv.h             |   9 ++-
 net/dsa/slave.c                | 161 +++++++++++++++++++++++++++++++++++++++--
 8 files changed, 352 insertions(+), 18 deletions(-)
Signature · 1 line
2.1.0