Skip to content

mm: improve handling of mm->exe_file

Davidlohr Bueso linux-audit linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3kernel/audit: consolidate handling of mm->exe_filekernel/audit.c kernel/audit.h kernel/auditsc.c+16 -169 replies
2/3kernel/audit: robustify handling of mm->exe_filekernel/audit.h+15 -92 replies
3/3tomoyo: robustify handling of mm->exe_filesecurity/tomoyo/common.c security/tomoyo/common.h security/tomoyo/util.c+38 -2611 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchTetsuo Handa
1/3
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH -part1 0/3] mm: improve handling of mm->exe_file

From: Davidlohr Bueso <[email protected]>

This series is the first in a few where I'm planning on removing the mmap_sem need for exe_file serialization. This is absurd and needs to have its own locking. Anyway, this is the final goal, and this series is just the first of a few that deals with unifying users of exe_file.

For now we only deal with audit and tomoyo, the most obvious naughty users, which only take the mmap_sem for exe_file. Over the years, relying on the mmap_sem for exe_file has made some callers increasingly messy and it is not as straightforward.

Essentially, we want to convert:

down_read(&mm->mmap_sem);
do_something_with(mm->exe_file);
up_read(&mm->mmap_sem);

to:

exe_file = get_mm_exe_file(mm); <--- mmap_sem is only held here. do_something_with(mm->exe_file);
fput(exe_file);

On its own, these patches already have value in that we reduce mmap_sem hold times and critical region. Once all users are standardized, converting the lock rules will be much easier.

Thanks!

Davidlohr Bueso (3):
kernel/audit: consolidate handling of mm->exe_file kernel/audit: robustify handling of mm->exe_file security/tomoyo: robustify handling of mm->exe_file

 kernel/audit.c           |  9 +--------
 kernel/audit.h           | 20 ++++++++++++++++++++
 kernel/auditsc.c         |  9 +--------
 security/tomoyo/common.c | 41 ++++++++++++++++++++++++++++++++++++++---
 security/tomoyo/common.h |  1 -
 security/tomoyo/util.c   | 22 ----------------------
 6 files changed, 60 insertions(+), 42 deletions(-)
Signature · 7 lines
2.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>