at86rf230: support for xtal trim and irq fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 1 replyIn review
- v42 patches 2 repliesSuperseded
- v32 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 1 reply | Superseded |
Changes in v5 from the cover letter
- remove platform data from at86rf230_local
- add note in cover-letter because at86rf2xx have different xtal_mode values
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | at86rf230: copy pdata to driver allocated spacedrivers/ | +25 | 0 replies | |
| 2/6 | at86rf230: add support for external xtal trimDocumentation/ drivers/ include/ | +54 | 0 replies | |
| 3/6 | at86rf230: remove tx_timeoutdrivers/ | +0 | 0 replies | |
| 4/6 | at86rf230: add irqmask mode settingdrivers/ | +5 | 0 replies | |
| 5/6 | at86rf230: add irq low-level for polaritydrivers/ | +2 | 0 replies | |
| 6/6 | at86rf230: add warning if edge-triggered irqDocumentation/ drivers/ | +7 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCHv5 bluetooth-next 0/6] at86rf230: support for xtal trim and irq fixes
Hi,
I moved the xtal_trim calculation example of available free schematics hardware transceivers into the source code now.
While testing I experience some issues with interrupt handling. The reason was an edge triggered interrupt gpio. To protect the IRQ resources we have a disable_irq <-> enable_irq path in our irq handler. If edge triggered and we get an irq while the irq is disabled the transceiver stucks in a state. The solution was to change from edge triggered irq to high-level irq, this will solve the issue and the irq will fire after calling enable_irq.
That's the reason why we should prever a high-level triggered gpio irq type, our current implementation can't handle edge triggered irq right now. I added some patches to printout a warning if a edge triggered irq is set.
- Alex
changes since v5:
- move note about xtal_trim value to driver code
- add patch to remove tx_timeout
- add patch for irqmask mode setting
- add patch for handling low-level irq polarity
- add patch for adding warning for edge triggered irq types
changes since v4:
- remove platform data from at86rf230_local
- add note in cover-letter because at86rf2xx have different xtal_mode values
changes since v3:
- remove setting of xtal_mode. Instead we setting xtal_trim only.
changes since v2:
- copy platform data to driver allocated space
Alexander Aring (6):
at86rf230: copy pdata to driver allocated space
at86rf230: add support for external xtal trim
at86rf230: remove tx_timeout
at86rf230: add irqmask mode setting
at86rf230: add irq low-level for polarity
at86rf230: add warning if edge-triggered irq
.../bindings/net/ieee802154/at86rf230.txt | 8 +- drivers/net/ieee802154/at86rf230.c | 118 +++++++++++++++------ include/linux/spi/at86rf230.h | 1 + 3 files changed, 91 insertions(+), 36 deletions(-)
Signature · 1 line
2.3.0