Skip to content

at86rf230: support for xtal trim and irq fixes

Alexander Aring linux-wpan 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 1 replyIn review
  2. v42 patches 2 repliesSuperseded
  3. v32 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v22 patches1 replySuperseded

Changes in v5 from the cover letter

- remove platform data from at86rf230_local
- add note in cover-letter because at86rf2xx have different xtal_mode values

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6at86rf230: copy pdata to driver allocated spacedrivers/net/ieee802154/at86rf230.c+25 -260 replies
2/6at86rf230: add support for external xtal trimDocumentation/devicetree/bindings/net/ieee802154/at86rf230.txt drivers/net/ieee802154/at86rf230.c include/linux/spi/at86rf230.h+54 -40 replies
3/6at86rf230: remove tx_timeoutdrivers/net/ieee802154/at86rf230.c+0 -50 replies
4/6at86rf230: add irqmask mode settingdrivers/net/ieee802154/at86rf230.c+5 -00 replies
5/6at86rf230: add irq low-level for polaritydrivers/net/ieee802154/at86rf230.c+2 -10 replies
6/6at86rf230: add warning if edge-triggered irqDocumentation/devicetree/bindings/net/ieee802154/at86rf230.txt drivers/net/ieee802154/at86rf230.c+7 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCHv5 bluetooth-next 0/6] at86rf230: support for xtal trim and irq fixes

Hi,

I moved the xtal_trim calculation example of available free schematics hardware transceivers into the source code now.

While testing I experience some issues with interrupt handling. The reason was an edge triggered interrupt gpio. To protect the IRQ resources we have a disable_irq <-> enable_irq path in our irq handler. If edge triggered and we get an irq while the irq is disabled the transceiver stucks in a state. The solution was to change from edge triggered irq to high-level irq, this will solve the issue and the irq will fire after calling enable_irq.

That's the reason why we should prever a high-level triggered gpio irq type, our current implementation can't handle edge triggered irq right now. I added some patches to printout a warning if a edge triggered irq is set.

- Alex

changes since v5:
- move note about xtal_trim value to driver code
- add patch to remove tx_timeout
- add patch for irqmask mode setting
- add patch for handling low-level irq polarity
- add patch for adding warning for edge triggered irq types

changes since v4:
- remove platform data from at86rf230_local
- add note in cover-letter because at86rf2xx have different xtal_mode values

changes since v3:
- remove setting of xtal_mode. Instead we setting xtal_trim only.

changes since v2:
- copy platform data to driver allocated space

Cc Werner Almesberger <[email protected]>
Cc Thomas Stilwell <[email protected]>

Alexander Aring (6):
at86rf230: copy pdata to driver allocated space
at86rf230: add support for external xtal trim
at86rf230: remove tx_timeout
at86rf230: add irqmask mode setting
at86rf230: add irq low-level for polarity
at86rf230: add warning if edge-triggered irq

 .../bindings/net/ieee802154/at86rf230.txt          |   8 +-
 drivers/net/ieee802154/at86rf230.c                 | 118 +++++++++++++++------
 include/linux/spi/at86rf230.h                      |   1 +
 3 files changed, 91 insertions(+), 36 deletions(-)
Signature · 1 line
2.3.0