Skip to content

net: dsa: mv88e6xxx: Add support for HW bridging

Guenter Roeck lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8net: dsa: mv88e6xxx: Factor out common initialization codedrivers/net/dsa/mv88e6123_61_65.c drivers/net/dsa/mv88e6171.c drivers/net/dsa/mv88e6352.c +2 more+22 -90 replies
2/8net: dsa: mv88e6xxx: Provide function for common port initializationdrivers/net/dsa/mv88e6xxx.c drivers/net/dsa/mv88e6xxx.h+26 -00 replies
3/8net: dsa: mv88e6xxx: Split mv88e6xxx_reg_read and mv88e6xxx_reg_writedrivers/net/dsa/mv88e6xxx.c+26 -90 replies
4/8net: dsa: mv88e6xxx: Add Hardware bridging supportdrivers/net/dsa/mv88e6xxx.c drivers/net/dsa/mv88e6xxx.h+300 -120 replies
5/8net: dsa: mv88e6352: Use common port initialization codedrivers/net/dsa/mv88e6352.c+1 -180 replies
6/8net: dsa: mv88e6123_61_65: Use common port configurationdrivers/net/dsa/mv88e6123_61_65.c+1 -180 replies
7/8net: dsa: mv88e6171: Use common port configurationdrivers/net/dsa/mv88e6171.c+1 -180 replies
8/8net: dsa: mv88e6352: Add support for hardware bridgingdrivers/net/dsa/mv88e6352.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFT/RFC PATCH 0/8] net: dsa: mv88e6xxx: Add support for HW bridging

This patch series applies on top of net-next, plus Florian's patches integrating dsa with SWITCHDEV for HW bridging. It also requires the patch 'net: dsa: Ensure that port array elements are initialized before being used'.

HW bridging support is currently only enabled for MV8865352, but it should be straightforward to enable support for other Marvell chips by adding three lines of initialization code to the respective source; see patch 8/8 for details. mv886e3131.c would also have to use mv88e6xxx_setup_port_common().

Patches 1-3 prepare the mv88e6xxx code for adding HW bridging support. Patch 4 adds core HW bridging support to the mv88e6xxx code. Patch 5-7 prepare the drivers for mv88e6352, mv88e6123_61_65, and mv88e6171 for HW bridging support, without actually enabling it. Patch 8 enables HW bridging support in the mv88e6352 driver.

Patches 5 and 8 could possibly be merged, but I thought it was better to keep them separate because they logically serve a different purpose.

Testing has been minimal, and only with MV88E6352. Ports can be added to and removed from a bridge, and I have been able to pass data through a port configured as bridge port.