Skip to content

Serialise oopses, BUGs, WARNs, dump_stack, soft lockups and hard lockups

Anton Blanchard linux-arm-kernel linuxppc-dev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Add die_spin_lock_{irqsave,irqrestore}include/linux/die_lock.h lib/Makefile lib/die_lock.c+67 -03 replies
2/7powerpc: Use die_spin_lock_{irqsave,irqrestore}arch/powerpc/kernel/traps.c+3 -210 replies
3/7arm: Use die_spin_lock_{irqsave,irqrestore}arch/arm/kernel/traps.c+3 -230 replies
4/7x86: Use die_spin_lock_{irqsave,irqrestore}arch/x86/kernel/dumpstack.c+3 -230 replies
5/7watchdog: Serialise soft lockup errors with die_spin_lock_{irqsave,irqrestore}kernel/watchdog.c+4 -00 replies
6/7dump_stack: Serialise dump_stack with die_spin_lock_{irqsave,irqrestore}lib/dump_stack.c+4 -360 replies
7/7powerpc: Serialise BUG and WARNs with die_spin_lock_{irqsave,irqrestore}arch/powerpc/kernel/traps.c+36 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] Serialise oopses, BUGs, WARNs, dump_stack, soft lockups and hard lockups

Every now and then I end up with an undebuggable issue because multiple CPUs hit something at the same time and everything is interleaved:

        CR: 48000082  XER: 00000000
        ,RI
        c0000003dc72fd10
        ,LE
        d0000000065b84e8
        Instruction dump:
        MSR: 8000000100029033

Very annoying.

Some architectures already have their own recursive locking for oopses and we have another version for serialising dump_stack.

Create a common version and use it everywhere (oopses, BUGs, WARNs, dump_stack, soft lockups and hard lockups). A few testcases were used to verify the series:

A trivial module to create concurrent WARNs, BUGs and oopses:

http://ozlabs.org/~anton/junkcode/warnstorm.tar.gz

And one to create concurrent soft and hard lockups:

http://ozlabs.org/~anton/junkcode/badguy.tar.gz

Anton Blanchard (7):
Add die_spin_lock_{irqsave,irqrestore}
powerpc: Use die_spin_lock_{irqsave,irqrestore}
arm: Use die_spin_lock_{irqsave,irqrestore}
x86: Use die_spin_lock_{irqsave,irqrestore}
watchdog: Serialise soft lockup errors with

    die_spin_lock_{irqsave,irqrestore}
  dump_stack: Serialise dump_stack with
    die_spin_lock_{irqsave,irqrestore}
  powerpc: Serialise BUG and WARNs with
    die_spin_lock_{irqsave,irqrestore}
 arch/arm/kernel/traps.c     | 26 ++---------------
 arch/powerpc/kernel/traps.c | 68 ++++++++++++++++++++++++++-------------------
 arch/x86/kernel/dumpstack.c | 26 ++---------------
 include/linux/die_lock.h    | 23 +++++++++++++++
 kernel/watchdog.c           |  4 +++
 lib/Makefile                |  1 +
 lib/die_lock.c              | 43 ++++++++++++++++++++++++++++
 lib/dump_stack.c            | 40 +++-----------------------
 8 files changed, 120 insertions(+), 111 deletions(-)
 create mode 100644 include/linux/die_lock.h
 create mode 100644 lib/die_lock.c
Signature · 1 line
2.1.0