new macro: find_closest()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 2 repliesIn review
- v34 patches 9 repliesSuperseded
- v24 patches 3 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 posting 2/2 | 4 patches | 1 reply | Superseded | |
| v1 posting 1/2 | 4 patches | 4 replies | Superseded |
Changes in v4 from the cover letter
- use >= instead of > in find_closest_descending()
- fix kernel docs
- make local variables in added macros less likely to cause namespace collisions
- use consistent statement expression syntax
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | util_macros.h: add find_closest() macroinclude/ | +40 | 1 reply | |
| 2/5 | documentation: update CodingStyle on local variables naming in macrosDocumentation/ | +13 | 1 reply | |
| 3/5 | hwmon: (ina2xx) replace ina226_avg_bits() with find_closest()drivers/ | +3 | 0 replies | |
| 4/5 | hwmon: (lm85) use find_closest() in x_TO_REG() functionsdrivers/ | +8 | 0 replies | |
| 5/5 | hwmon: (w83795) use find_closest_descending() in pwm_freq_to_reg()drivers/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 0/5] new macro: find_closest()
This series proposes to unduplicate the code used to find the member in an array closest to 'x'.
The first patch adds a macro implementing the algorithm in two flavors - for arrays sorted in ascending and descending order. The second updates Documentation/CodingStyle on the naming convention for local variables in macros resembling functions. Other three patches replace duplicated code with calls to one of these macros in some hwmon drivers.
v4:
- use >= instead of > in find_closest_descending()
- fix kernel docs
- make local variables in added macros less likely to cause namespace collisions
- use consistent statement expression syntax
v3:
https://lkml.org/lkml/2015/3/19/369
v2:
https://lkml.org/lkml/2015/3/10/582
v1:
https://lkml.org/lkml/2015/2/24/509
Bartosz Golaszewski (5):
util_macros.h: add find_closest() macro
documentation: update CodingStyle on local variables naming in macros
hwmon: (ina2xx) replace ina226_avg_bits() with find_closest()
hwmon: (lm85) use find_closest() in x_TO_REG() functions
hwmon: (w83795) use find_closest_descending() in pwm_freq_to_reg()
Documentation/CodingStyle | 13 +++++++++++++ drivers/hwmon/ina2xx.c | 17 +++-------------- drivers/hwmon/lm85.c | 26 ++++++++------------------ drivers/hwmon/w83795.c | 8 +++----- include/linux/util_macros.h | 40 ++++++++++++++++++++++++++++++++++++++++ 5 files changed, 67 insertions(+), 37 deletions(-) create mode 100644 include/linux/util_macros.h
Signature · 1 line
2.1.4