Skip to content

Synopsis 8250 serial port driver fix

Jonathan Richardson linux-arm-kernel linux-devicetree linux-input linux-pwm linux-serial lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 patch 2 repliesIn review
  2. v11 patch 3 repliesSuperseded

Changes in v2 from the cover letter

- Changed DT properties from strings to booleans as suggested by Arnd. Documentation updated accordingly.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1serial: 8250_dw: Fix get_mctrl behaviourDocumentation/devicetree/bindings/serial/snps-dw-apb-uart.txt drivers/tty/serial/8250/8250_dw.c+48 -02 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchJD (Jiandong) Zheng
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/1] Synopsis 8250 serial port driver fix

Hi,

This patchset fixes a bug in the Synopsis 8250 serial driver which causes the driver to hang. The bug occurs on simple 2 wire serial ports when modem control signalling has been enabled. It can be reproduced from user space by enabling modem control signals (stty -clocal), then opening a serial port and polling for data available to read with a timeout. A properly implemented driver will ignore the control signals and the call to poll will return. The current version of the driver hangs forever on the call to poll despite the timeout.

Jon

Changes from v1:
- Changed DT properties from strings to booleans as suggested by Arnd. Documentation updated accordingly.

Desmond Liu (1):
serial: 8250_dw: Fix get_mctrl behaviour

 .../bindings/serial/snps-dw-apb-uart.txt           |   16 ++++++++++
 drivers/tty/serial/8250/8250_dw.c                  |   32 ++++++++++++++++++++
 2 files changed, 48 insertions(+)
Signature · 1 line
1.7.9.5