Skip to content

x86, boot: clean up setup_data handling

Yinghai Lu linux-efi linux-pci lkml stable 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 3/38 patches 3 repliesIn review
  2. v3 posting 2/32 of 8 patches 0 repliesSuperseded
  3. v3 posting 1/37 patches 40 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v215 patches25 repliesSuperseded
v18 patches17 repliesSuperseded

Patches in v3 posting 3/3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8x86: Kill E820_RESERVED_KERNarch/x86/include/uapi/asm/e820.h arch/x86/kernel/e820.c arch/x86/kernel/setup.c +2 more+7 -483 replies
2/8x86, efi: Copy SETUP_EFI data and access directlyarch/x86/include/asm/efi.h arch/x86/platform/efi/efi.c arch/x86/platform/efi/efi_64.c +1 more+21 -300 replies
3/8x86, of: Let add_dtb reserve setup_data locallyarch/x86/include/asm/prom.h arch/x86/kernel/devicetree.c+31 -210 replies
4/8x86, boot: Add add_pci handler for SETUP_PCIarch/x86/include/asm/pci.h arch/x86/kernel/setup.c arch/x86/pci/common.c+41 -140 replies
5/8x86: Kill not used setup_data handling codearch/x86/kernel/kdebugfs.c arch/x86/kernel/setup.c+0 -1590 replies
6/8x86, boot, PCI: Convert SETUP_PCI data to listarch/x86/include/asm/pci.h arch/x86/kernel/setup.c arch/x86/pci/common.c+65 -150 replies
7/8x86, boot, PCI: Copy SETUP_PCI rom to kernel spacearch/x86/pci/common.c+45 -20 replies
8/8x86, boot, PCI: Export SETUP_PCI data via sysfsarch/x86/pci/common.c+175 -00 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchLee, Chun-Yi
1/8T-b
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] x86, boot: clean up setup_data handling

Now setup_data is reserved via memblock and e820 and different handlers have different ways, and it is confusing.
1. SETUP_E820_EXT: is consumed early and will not copy or access again. have memory wasted.
2. SETUP_EFI: is accessed via ioremap every time at early stage. have memory wasted.
3. SETUP_DTB: is copied locally.
have memory wasted.
4. SETUP_PCI: is accessed via ioremap for every pci devices, even run-time.
5. SETUP_KASLR: is accessed early, will not copy or access again. have memory wasted.

Also setup_data is exported to debugfs for debug purpose.

Here will convert to let every handler to decide how to handle it. and will not reserve the setup_data generally, so will not waste memory and also make memblock/e820 keep page aligned.
1. not touch E820 anymore.
2. copy SETUP_EFI to __initdata variable and access it without ioremap.
3. SETUP_DTB: reserver and copy to local and free.
4. SETUP_PCI: reverve localy and convert to list, to avoid keeping ioremap.
5. export SETUP_PCI via sysfs.

Also put them in:
git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-x86-4.0-rc2-setup_data

Should be materials for v4.1.

Thanks

Yinghai Lu

-v3: separated with kasl patches, and fix early_ioremap return checking.

Yinghai Lu (8):
x86: Kill E820_RESERVED_KERN
x86, efi: Copy SETUP_EFI data and access directly x86, of: Let add_dtb reserve setup_data locally x86, boot: Add add_pci handler for SETUP_PCI
x86: Kill not used setup_data handling code x86, boot, PCI: Convert SETUP_PCI data to list x86, boot, PCI: Copy SETUP_PCI rom to kernel space x86, boot, PCI: Export SETUP_PCI data via sysfs

 arch/x86/include/asm/efi.h       |   2 +-
 arch/x86/include/asm/pci.h       |   4 +
 arch/x86/include/asm/prom.h      |   9 +-
 arch/x86/include/uapi/asm/e820.h |   9 --
 arch/x86/kernel/devicetree.c     |  43 +++---
 arch/x86/kernel/e820.c           |   6 +-
 arch/x86/kernel/kdebugfs.c       | 142 ------------------
 arch/x86/kernel/setup.c          |  52 ++-----
 arch/x86/kernel/tboot.c          |   3 +-
 arch/x86/mm/init_64.c            |  11 +-
 arch/x86/pci/common.c            | 316 ++++++++++++++++++++++++++++++++++++---
 arch/x86/platform/efi/efi.c      |  13 +-
 arch/x86/platform/efi/efi_64.c   |  13 +-
 arch/x86/platform/efi/quirks.c   |  23 +--
 14 files changed, 371 insertions(+), 275 deletions(-)
Signature · 1 line
1.8.4.5