Skip to content

N900 Modem Speech Support

Sebastian Reichel linux-api linux-omap lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v22 patches 9 repliesSuperseded
  3. v19 patches 8 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2HSI: cmt_speech: Add cmt-speech driverdrivers/hsi/clients/Kconfig drivers/hsi/clients/Makefile drivers/hsi/clients/cmt_speech.c +2 more+1581 -11 reply
2/2HSI: nokia-modem: Add cmt-speech supportdrivers/hsi/clients/Kconfig drivers/hsi/clients/nokia-modem.c+32 -21 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAaro Koskinen
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCHv3 0/2] N900 Modem Speech Support

Hi,

This patchset contains the missing speech data support for the Nokia N900 modem.

Userland access goes via /dev/cmt_speech. The API is implemented in libcmtspeechdata, which is used by ofono and the freesmartphone.org project. Apart from that the device is also used by the phone binaries distributed with Maemo. So while this is a new userland ABI for the mainline kernel it has been tested in the wild for some years.

Simple Testing of the API can be done by checking out libcmtspeechdata [0], building the test tool and executing it. The tool will loop back audio data received from the caller.

I have prepared a kernel branch for this patchset, which can be found at [1].

Changes since PATCHv2 [3]:
* Change MODULE_LICENSE from "GPL" to "GPL v2"
* Add some cleanups suggested by Pavel
* Add missing dependency on SSI_PROTOCOL in Kconfig

Changes since PATCHv1 [2]:
* Squash cmt-speech patches together
* cs_alloc_cmds(): GFP_ATOMIC -> GFP_KERNEL
* CS_SET_WAKELINE ioctl: Add sanity check

[0] https://lkml.org/lkml/2015/2/11/526
[1] git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git branch/cmt-speech-2
[2] https://lkml.org/lkml/2015/3/1/282
[3] https://lkml.org/lkml/2015/3/4/1139

-- Sebastian

Kai Vehmanen (1):
HSI: cmt_speech: Add cmt-speech driver

Sebastian Reichel (1):
HSI: nokia-modem: Add cmt-speech support

 drivers/hsi/clients/Kconfig          |   12 +-
 drivers/hsi/clients/Makefile         |    1 +
 drivers/hsi/clients/cmt_speech.c     | 1456 ++++++++++++++++++++++++++++++++++
 drivers/hsi/clients/nokia-modem.c    |   32 +-
 include/uapi/linux/hsi/Kbuild        |    2 +-
 include/uapi/linux/hsi/cs-protocol.h |  113 +++
 6 files changed, 1613 insertions(+), 3 deletions(-)
 create mode 100644 drivers/hsi/clients/cmt_speech.c
 create mode 100644 include/uapi/linux/hsi/cs-protocol.h
Signature · 1 line
2.1.4