Skip to content

tools build: Move features framework into tools/build

Jiri Olsa lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 7 repliesIn review
  2. v114 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- omitted patch 1 from original version (Ingo)
- added features build output dump (Arnaldo)
- better scripting in features test (Namhyung)
- fixed test-all for pthread-attr-setaffinity-np
- removed main_test_libbabeltrace from test-all
- patches reordered

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15perf build: Disable default check for libbabeltracetools/perf/config/Makefile tools/perf/config/feature-checks/Makefile tools/perf/config/feature-checks/test-all.c+14 -84 replies
2/15perf build: Add dump of features buildtools/perf/config/feature-checks/Makefile+3 -20 replies
3/15perf build: Fix pthread-attr-setaffinity-np include in test-alltools/perf/config/feature-checks/test-all.c+1 -10 replies
4/15perf build: Get rid of LIB_INCLUDE variabletools/perf/config/Makefile+1 -20 replies
5/15perf build: Rename CORE_FEATURE_TESTS to FEATURE_TESTStools/perf/config/Makefile+6 -60 replies
6/15perf build: Get rid of VF_FEATURE_TESTStools/perf/config/Makefile+7 -250 replies
7/15perf build: Rename display_lib into feature_displaytools/perf/config/Makefile+6 -60 replies
8/15perf build: Rename display_vf to feature_verbosetools/perf/config/Makefile+2 -20 replies
9/15perf build: Rename PERF-FEATURES into FEATURE-DUMPtools/perf/Makefile.perf tools/perf/config/Makefile+7 -70 replies
10/15perf build: Rename feature_print_var_code to print_var_codetools/perf/config/Makefile+12 -110 replies
11/15perf build: Separate feature make support into config/Makefile.featuretools/perf/config/Makefile tools/perf/config/Makefile.feature+168 -1640 replies
12/15perf build: Make features checks directory configurabletools/perf/config/Makefile.feature+4 -20 replies
13/15tools build: Move feature checks code under tools/buildtools/build/Makefile.feature tools/build/feature/.gitignore tools/build/feature/Makefile +65 more+784 -7840 replies
14/15tools build: Allow to override feature checks setuptools/build/Documentation/Feature.txt tools/build/Makefile.feature tools/build/tests/features/Makefile +2 more+137 -30 replies
15/15tools build: Fix feature_check name clashtools/build/Makefile.feature+3 -30 replies

Reviews trailers per patch

1 of 15 patches has a Reviewed-by or Acked-by.

PatchIngo Molnar
1/15A-b
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 00/15] tools build: Move features framework into tools/build

hi,
moving features detection framework from perf to 'tools/build' plus other minor fixes.

v2 changes:
- omitted patch 1 from original version (Ingo)
- added features build output dump (Arnaldo)
- better scripting in features test (Namhyung)
- fixed test-all for pthread-attr-setaffinity-np
- removed main_test_libbabeltrace from test-all
- patches reordered

It's also available in:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/build

thanks,
jirka

Suggested-by Ingo Molnar <[email protected]>
Signed-off-by Jiri Olsa <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Corey Ashford <[email protected]>
Cc David Ahern <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>

---
Jiri Olsa (15):
perf build: Disable default check for libbabeltrace
perf build: Add dump of features build
perf build: Fix pthread-attr-setaffinity-np include in test-all perf build: Get rid of LIB_INCLUDE variable
perf build: Rename CORE_FEATURE_TESTS to FEATURE_TESTS perf build: Get rid of VF_FEATURE_TESTS
perf build: Rename display_lib into feature_display
perf build: Rename display_vf to feature_verbose
perf build: Rename PERF-FEATURES into FEATURE-DUMP
perf build: Rename feature_print_var_code to print_var_code perf build: Separate feature make support into config/Makefile.feature perf build: Make features checks directory configurable tools build: Move feature checks code under tools/build tools build: Allow to override feature checks setup
tools build: Fix feature_check name clash

 tools/build/Documentation/Feature.txt              |  93 +++++++++
 tools/build/Makefile.feature                       | 169 ++++++++++++++++
 .../feature-checks => build/feature}/.gitignore    |   0
 .../feature-checks => build/feature}/Makefile      |   7 +-
 .../feature-checks => build/feature}/test-all.c    |  11 +-
 .../feature}/test-backtrace.c                      |   0
 .../feature-checks => build/feature}/test-bionic.c |   0
 .../feature}/test-compile.c                        |   0
 .../feature}/test-cplus-demangle.c                 |   0
 .../feature-checks => build/feature}/test-dwarf.c  |   0
 .../feature}/test-fortify-source.c                 |   0
 .../feature-checks => build/feature}/test-glibc.c  |   0
 .../feature}/test-gtk2-infobar.c                   |   0
 .../feature-checks => build/feature}/test-gtk2.c   |   0
 .../feature-checks => build/feature}/test-hello.c  |   0
 .../feature}/test-libaudit.c                       |   0
 .../feature}/test-libbabeltrace.c                  |   0
 .../feature-checks => build/feature}/test-libbfd.c |   0
 .../feature}/test-libdw-dwarf-unwind.c             |   0
 .../feature}/test-libelf-getphdrnum.c              |   0
 .../feature}/test-libelf-mmap.c                    |   0
 .../feature-checks => build/feature}/test-libelf.c |   0
 .../feature}/test-libnuma.c                        |   0
 .../feature}/test-libperl.c                        |   0
 .../feature}/test-libpython-version.c              |   0
 .../feature}/test-libpython.c                      |   0
 .../feature}/test-libslang.c                       |   0
 .../feature}/test-libunwind-debug-frame.c          |   0
 .../feature}/test-libunwind.c                      |   0
 .../feature}/test-pthread-attr-setaffinity-np.c    |   0
 .../feature}/test-stackprotector-all.c             |   0
 .../feature}/test-sync-compare-and-swap.c          |   0
 .../feature}/test-timerfd.c                        |   0
 .../feature-checks => build/feature}/test-zlib.c   |   0
 tools/build/tests/features/Makefile                |  23 +++
 tools/build/tests/features/Makefile.test1          |  16 ++
 tools/build/tests/run.sh                           |   4 +-
 tools/perf/Makefile.perf                           |   4 +-
 tools/perf/config/Makefile                         | 212 ++-------------------
 39 files changed, 334 insertions(+), 205 deletions(-)
 create mode 100644 tools/build/Documentation/Feature.txt
 create mode 100644 tools/build/Makefile.feature
 rename tools/{perf/config/feature-checks => build/feature}/.gitignore (100%)
 rename tools/{perf/config/feature-checks => build/feature}/Makefile (93%)
 rename tools/{perf/config/feature-checks => build/feature}/test-all.c (92%)
 rename tools/{perf/config/feature-checks => build/feature}/test-backtrace.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-bionic.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-compile.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-cplus-demangle.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-dwarf.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-fortify-source.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-glibc.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-gtk2-infobar.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-gtk2.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-hello.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libaudit.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libbabeltrace.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libbfd.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libdw-dwarf-unwind.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libelf-getphdrnum.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libelf-mmap.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libelf.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libnuma.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libperl.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libpython-version.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libpython.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libslang.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libunwind-debug-frame.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-libunwind.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-pthread-attr-setaffinity-np.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-stackprotector-all.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-sync-compare-and-swap.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-timerfd.c (100%)
 rename tools/{perf/config/feature-checks => build/feature}/test-zlib.c (100%)
 create mode 100644 tools/build/tests/features/Makefile
 create mode 100644 tools/build/tests/features/Makefile.test1

Read the cover letter in its thread