Skip to content

sata_dwc_460ex: move to generic DMA driver

Andy Shevchenko linux-ide linuxppc-dev 1 version In review

Get series with b4
b4 am 1425415282-3750-1-git-send-email-andriy.shevchenko@linux.intel.com

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2sata_dwc_460ex: move to generic DMA driverdrivers/ata/sata_dwc_460ex.c+122 -6143 replies
2/2sata_dwc_460ex: re-use hsdev->dev instead of dwc_devdrivers/ata/sata_dwc_460ex.c+11 -121 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/2] sata_dwc_460ex: move to generic DMA driver

The SATA implementation based on two actually different devices, i.e. SATA and DMA controllers.

For Synopsys DesignWare DMA we have already a generic implementation of the driver. Thus, the patch 1/2 converts the code to use DMAEngine framework and dw_dmac driver.

In future it will be better to split the devices inside DTS as well like it's done on other platforms and remove hardcoded parameters of DMA controller.

Besides it's a nice clean up it removes a lot of warnings produced by the original code, that pissed off even Linus [1]. Though, this series doesn't re-enable COMPILE_TEST for this module.

The driver is compile tested only on x86. So, it would be nice if anyone who has either AMCC 460EX Canyonlands board or similar SATA controller in possession can test this.

[1] http://www.spinics.net/lists/linux-ide/msg50334.html

Andy Shevchenko (2):
sata_dwc_460ex: move to generic DMA driver
sata_dwc_460ex: re-use hsdev->dev instead of dwc_dev

 drivers/ata/sata_dwc_460ex.c | 753 ++++++++-----------------------------------
 1 file changed, 130 insertions(+), 623 deletions(-)
Signature · 1 line
2.1.4