Skip to content

TTY: fix tty_wait_until_sent on 64-bit machines

Johan Hovold linux-serial lkml netdev stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: irda: fix wait_until_sent poll timeoutnet/irda/ircomm/ircomm_tty.c+3 -10 replies
2/5TTY: bfin_jtag_comm: remove incorrect wait_until_sent operationdrivers/tty/bfin_jtag_comm.c+0 -131 reply
3/5USB: serial: fix infinite wait_until_sent timeoutdrivers/usb/serial/generic.c+3 -20 replies
4/5TTY: fix tty_wait_until_sent on 64-bit machinesdrivers/tty/tty_ioctl.c+9 -31 reply
5/5TTY: fix tty_wait_until_sent maximum timeoutdrivers/tty/tty_ioctl.c+3 -31 reply

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchPeter Hurley
1/5
2/5R-b
3/5
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] TTY: fix tty_wait_until_sent on 64-bit machines

This series fixes an overflow bug in tty_wait_until_sent, which is currently broken on 64-bit machines for most TTY drivers (with serial-core being the notable exception).

The final patch makes the tty_wait_until_sent timeout a maximum one so that we actually honour the closing-wait timeout.

All but the second (clean-up) and final patch are marked for stable.

These patches are for v4.0 and I suggest Greg takes them all through the TTY tree.

Thanks,
Johan

Johan Hovold (5):
net: irda: fix wait_until_sent poll timeout
TTY: bfin_jtag_comm: remove incorrect wait_until_sent operation
USB: serial: fix infinite wait_until_sent timeout
TTY: fix tty_wait_until_sent on 64-bit machines
TTY: fix tty_wait_until_sent maximum timeout

 drivers/tty/bfin_jtag_comm.c | 13 -------------
 drivers/tty/tty_ioctl.c      | 16 +++++++++++-----
 drivers/usb/serial/generic.c |  5 +++--
 net/irda/ircomm/ircomm_tty.c |  4 +++-
 4 files changed, 17 insertions(+), 21 deletions(-)
Signature · 1 line
2.0.5