Skip to content

libxl: try to support IGD passthrough for qemu upstream

Tiejun Chen qemu-devel xen-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest posting 2/22 patches 5 repliesIn review
  2. v4 posting 1/20 of 2 patches 0 repliesSuperseded
  3. v3 posting 2/22 patches 44 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v3 posting 1/20 of 2 patches0 repliesSuperseded
v2 posting 2/22 patches38 repliesSuperseded
v2 posting 1/20 of 2 patches0 repliesSuperseded
v12 patches30 repliesSuperseded

v3 from the cover letter

* Refine some codes based on Campbell's feedback so thanks for Campbell's kind guideline to patch #2
* Update the manpages in patch #2

Patches in v4 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2libxl: introduce libxl__is_igd_vga_passthrutools/libxl/libxl_internal.h tools/libxl/libxl_pci.c+126 -00 replies
1/2libxl: introduce libxl__is_igd_vga_passthrutools/libxl/libxl_internal.h tools/libxl/libxl_pci.c+126 -00 replies
2/2libxl: introduce gfx_passthru_kinddocs/man/xl.cfg.pod.5 tools/libxl/libxl.h tools/libxl/libxl_dm.c +2 more+97 -100 replies
2/2libxl: introduce gfx_passthru_kinddocs/man/xl.cfg.pod.5 tools/libxl/libxl.h tools/libxl/libxl_dm.c +2 more+97 -103 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchIan Campbell
1/2A-b A-b
1/2A-b A-b
2/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [v4][PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

Ian,

As we discussed previously,

http://patchwork.ozlabs.org/patch/457055/

now it's time to push this into on xen/tools side since all qemu stuffs have been merged.

https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02094.html

v4:

Ian,

Actually we had v3.5 online previously, which was reviewed by you.

http://permalink.gmane.org/gmane.comp.emulators.qemu/329100

So here I just bring a little bit to refine code just for patch #2 according to out last conversation.

v3:

* Refine some codes based on Campbell's feedback so thanks for Campbell's kind guideline to patch #2
* Update the manpages in patch #2

v2:

* Refine patch #2's head description
* Improve codes quality inside patch #1 based on Wei's comments
* Refill the summary inside patch #0 based on Konrad and Wei's suggestion

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,igd-passthru=on".

https://lists.nongnu.org/archive/html/qemu-devel/2015-01/msg02050.html

This need to bring a change on tool side.

After a discussion with Campbell, we'd like to construct a table to record all IGD devices we can support. If we hit that table, we should pass that option. And so we also introduce a new field of type, 'gfx_passthru_kind', to cooperate with 'gfx_passthru' to cover all scenarios like this,

gfx_passthru = 0 => sets build_info.u.gfx_passthru to false
gfx_passthru = 1 => sets build_info.u.gfx_passthru to true and
build_info.u.gfx_passthru_kind to DEFAULT
gfx_passthru = "igd" => sets build_info.u.gfx_passthru to false
and build_info.u.gfx_passthru_kind to IGD

And note actually that option "-gfx_passthru" is just introduced to work for qemu-xen-traditional so we should get this away from libxl__build_device_model_args_new() in the case of qemu upstream.

----------------------------------------------------------------
Tiejun Chen (2):
libxl: introduce libxl__is_igd_vga_passthru
libxl: introduce gfx_passthru_kind

 docs/man/xl.cfg.pod.5        |  35 ++++++++--
 tools/libxl/libxl.h          |   6 ++
 tools/libxl/libxl_dm.c       |  46 +++++++++++--
 tools/libxl/libxl_internal.h |   2 +
 tools/libxl/libxl_pci.c      | 124 +++++++++++++++++++++++++++++++++++
 tools/libxl/libxl_types.idl  |   6 ++
 tools/libxl/xl_cmdimpl.c     |  14 +++-
 7 files changed, 223 insertions(+), 10 deletions(-)

Thanks
Tiejun